From owner-freebsd-audit Tue Nov 7 12:12:22 2000 Delivered-To: freebsd-audit@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.100.7]) by hub.freebsd.org (Postfix) with ESMTP id 6E15037B479 for ; Tue, 7 Nov 2000 12:12:19 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.9.3/8.9.3) with ESMTP id PAA636096; Tue, 7 Nov 2000 15:12:11 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20001107164039.E68293@lucifer.bart.nl> References: <20001024140510.G93799@lucifer.bart.nl> <20001024222716.B2020@lucifer.bart.nl> <20001107164039.E68293@lucifer.bart.nl> Date: Tue, 7 Nov 2000 15:12:09 -0500 To: Jeroen Ruigrok van der Werven From: Garance A Drosihn Subject: Re: Fixing mktemp() call in lpd/printjob.c (logging) Cc: audit@FreeBSD.ORG, freebsd-print@bostonradio.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At 4:40 PM +0100 11/7/00, Jeroen Ruigrok van der Werven wrote: >-On [20001107 01:45], Garance A Drosihn (drosih@rpi.edu) wrote: >>-static char tempfile[] = "errsXXXXXX"; /* file name for filter errors */ >>+/* tempErrsfile is the filename used to catch stderr from exec-ing >>filters */ >>+static char tempErrsfile[] = "errs.XXXXXXX"; > >Well, with this variable naming you divert from the style used in the >total source code. Well, I do want that renamed, due to other updates I plan to install as time permits. How about 'temperrsf' or maybe 'tempstderr'? Assuming no one sees some security problem with this, I'll commit the update (with a different variable name) sometime later this week. -- --- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message