From owner-freebsd-stable@freebsd.org  Wed Dec 30 02:06:15 2015
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9912DA56FFC
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Wed, 30 Dec 2015 02:06:15 +0000 (UTC)
 (envelope-from michael+lists@burnttofu.net)
Received: from burnttofu.net (burnttofu.net [IPv6:2607:fc50:1:9d00::9977])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "burnttofu.net", Issuer "burnttofu.net" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 799C21169
 for <freebsd-stable@freebsd.org>; Wed, 30 Dec 2015 02:06:15 +0000 (UTC)
 (envelope-from michael+lists@burnttofu.net)
Received: from kimberton.burnttofu.net ([IPv6:2601:643:8400:3e00::7777])
 (authenticated bits=0)
 by burnttofu.net (8.15.2/8.14.9) with ESMTPSA id tBU2649c039217
 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
 Tue, 29 Dec 2015 21:06:11 -0500 (EST)
 (envelope-from michael+lists@burnttofu.net)
Subject: Re: SOL_TCP def?
To: Jonathan Chen <jonc@chen.org.nz>, freebsd-stable@freebsd.org
References: <CAJuc1zM3dGVPVN0u8C_utKdOGb7edSy3UinQpOokES=2j05OcQ@mail.gmail.com>
From: Michael Sinatra <michael+lists@burnttofu.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <56833C0B.6040609@burnttofu.net>
Date: Tue, 29 Dec 2015 18:06:03 -0800
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAJuc1zM3dGVPVN0u8C_utKdOGb7edSy3UinQpOokES=2j05OcQ@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (burnttofu.net [IPv6:2607:fc50:1:9d00::9977]);
 Tue, 29 Dec 2015 21:06:12 -0500 (EST)
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Dec 2015 02:06:15 -0000

On 12/29/15 10:28, Jonathan Chen wrote:
> Hi,
> 
> I've just recently updated on 10/STABLE to r292878; and on rebuilding
> devel/gsoap, I get:
> 
> cc -DHAVE_CONFIG_H -I. -I..       -DFREEBSD -O2 -pipe
> -fstack-protector -fno-strict-aliasing -MT libgsoap_a-stdsoap2.o -MD
> -MP -MF .deps/libgsoap_a-stdsoap2.Tpo -c -o libgsoap_a-stdsoap2.o
> `test -f 'stdsoap2.c' || echo './'`stdsoap2.c
> stdsoap2.c:5107:64: error: use of undeclared identifier 'SOL_TCP'
>   if (!(soap->omode & SOAP_IO_UDP) && setsockopt(soap->master,
> SOL_TCP, TCP_FASTOPEN, (char*)&set, sizeof(int)))

As Dmitry notes, you must patch both stdsoap2.c and stdsoap2.cpp to use
IPPROTO_TCP instead of SOL_TCP.  The reason for the change is that the
code looks to see if TCP_FASTOPEN is defined, and, if so, it assumes
that it's some sort of Linux-based stack that uses SOL_TCP instead of
IPPROTO_TCP.  Once TCP Fast Open (RFC 7413) was MFC'd to STABLE,
TCP_FASTOPEN became defined so gsoap tried to use it with the wrong
SOL_TCP definition.

michael