From owner-freebsd-hackers@FreeBSD.ORG  Tue Nov  3 17:50:39 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C4D0B1065672;
	Tue,  3 Nov 2009 17:50:39 +0000 (UTC)
	(envelope-from a_best01@uni-muenster.de)
Received: from zivm-exrelay1.uni-muenster.de (ZIVM-EXRELAY1.UNI-MUENSTER.DE
	[128.176.192.14])
	by mx1.freebsd.org (Postfix) with ESMTP id 28E548FC27;
	Tue,  3 Nov 2009 17:50:38 +0000 (UTC)
X-IronPort-AV: E=Sophos;i="4.44,675,1249250400"; d="scan'208";a="287266192"
Received: from zivmaildisp1.uni-muenster.de (HELO
	ZIVMAILUSER04.UNI-MUENSTER.DE) ([128.176.188.85])
	by zivm-relay1.uni-muenster.de with ESMTP; 03 Nov 2009 18:50:38 +0100
Received: by ZIVMAILUSER04.UNI-MUENSTER.DE (Postfix, from userid 149459)
	id 1C89A1B07BE; Tue,  3 Nov 2009 18:50:38 +0100 (CET)
Date: Tue, 03 Nov 2009 18:50:37 +0100 (CET)
From: Alexander Best <alexbestms@math.uni-muenster.de>
Sender: <a_best01@uni-muenster.de>
Organization: Westfaelische Wilhelms-Universitaet Muenster
To: <rea-fbsd@codelabs.ru>,
 Alexander Best <alexbestms@math.uni-muenster.de>
Message-ID: <permail-2009110317503780e26a0b00007fc8-a_best01@message-id.uni-muenster.de>
In-Reply-To: <Uzn3rwzsWEtTrYaz4Wl3Xnqcm9I@SNwcwk2DeGhgeFqjLEiQrEAOiKg>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: Ed Schouten <ed@80386.nl>, freebsd-hackers@freebsd.org,
	pluknet <pluknet@gmail.com>, Antony Mawer <lists@mawer.org>,
	Dag-Erling Sm?rgrav <des@des.no>, rafan@freebsd.org
Subject: Re: help needed to fix contrib/ee crash/exit when receiving SIGWINCH
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2009 17:50:39 -0000

Eygene Ryabinkin schrieb am 2009-11-03:
> Mon, Nov 02, 2009 at 10:32:29PM +0100, Alexander Best wrote:
> > ok. the pr stays in patched state. right now the patch is in HEAD,
> > 8-STABLE and 8.0-RELEASE. rafan is thinking about mfc'ing the patch
> > to
> > 6-stable and 7-stable. however if somebody is willing to modify the
> > patch so it applies to those branches that'll be great

> Patch applies cleanly to the 7-STABLE, moreover, lib_getch.c from it
> has the same logics and fifo_push is essentially unmodified in the
> areas that are relevant for this flaw.

> I had patched 7-STABLE on the test machine, brought ee from 8.x and
> verified that unpatched ncurses give immediate exit, while patched
> curses give working ee in respect to the SIGWINCH.

> I had also mildly tested vi and sysinstall on the patched 7-STABLE
> and found no visible regressions.

great. so do we need/want the patch in 6.x?

alex