From owner-freebsd-mips@FreeBSD.ORG Sun Mar 18 22:47:02 2012 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 06B6D106564A; Sun, 18 Mar 2012 22:47:02 +0000 (UTC) (envelope-from gonzo@hq.bluezbox.com) Received: from hq.bluezbox.com (hq.bluezbox.com [70.38.37.145]) by mx1.freebsd.org (Postfix) with ESMTP id BA1C58FC0C; Sun, 18 Mar 2012 22:47:01 +0000 (UTC) Received: from localhost ([127.0.0.1]) by hq.bluezbox.com with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.73 (FreeBSD)) (envelope-from ) id 1S9OsH-000B79-6z; Sun, 18 Mar 2012 15:46:53 -0700 Message-ID: <4F6665E3.1010802@bluezbox.com> Date: Sun, 18 Mar 2012 15:46:59 -0700 From: Oleksandr Tymoshenko User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Adrian Chadd References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: gonzo@hq.bluezbox.com X-Spam-Level: ---- X-Spam-Report: Spam detection software, running on the system "hq.bluezbox.com", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: On 18/03/2012 12:42 AM, Adrian Chadd wrote: > Hi! > > On 18 March 2012 00:24, Oleksandr Tymoshenko wrote: >> Hello, >> >> Proposed patch fixes some issues in hwpmc(4) and makes adding support >> for more MIPS CPUs much easier. I'd appreciate reviews and any >> feedback. >> >> http://people.freebsd.org/~gonzo/mips/pmc-2.diff > > Thanks for this! > > Some of this stuff looks like it can be committed as small, standalone fixes: > > * pmc_syscall_args is standalone, right? > * changing the MIPS rtld is also a separate commit > * same deal with pmcstat_log.c? But this would also impact non-MIPS > platforms so we'd have to test those? [...] Content analysis details: (-4.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Cc: freebsd-mips@freebsd.org Subject: Re: hwpmc(4) MIPS code refactoring / bugfixes X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Mar 2012 22:47:02 -0000 On 18/03/2012 12:42 AM, Adrian Chadd wrote: > Hi! > > On 18 March 2012 00:24, Oleksandr Tymoshenko wrote: >> Hello, >> >> Proposed patch fixes some issues in hwpmc(4) and makes adding support >> for more MIPS CPUs much easier. I'd appreciate reviews and any >> feedback. >> >> http://people.freebsd.org/~gonzo/mips/pmc-2.diff > > Thanks for this! > > Some of this stuff looks like it can be committed as small, standalone fixes: > > * pmc_syscall_args is standalone, right? > * changing the MIPS rtld is also a separate commit > * same deal with pmcstat_log.c? But this would also impact non-MIPS > platforms so we'd have to test those? These are indeed self-contained fixes and I was going to make them separate commits. I tested syscall args fix and pmcstat_log.c changes on amd64 box - works fine.