From owner-svn-src-head@freebsd.org Wed Mar 14 22:51:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6555BF4F991; Wed, 14 Mar 2018 22:51:35 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x229.google.com (mail-lf0-x229.google.com [IPv6:2a00:1450:4010:c07::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DF2DA7B2A5; Wed, 14 Mar 2018 22:51:34 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x229.google.com with SMTP id e5-v6so3225992lfb.7; Wed, 14 Mar 2018 15:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ivQ+5w6gqTTydb1tqWIWXFraOTP1/upmkImTTfJeDec=; b=uW15boNDWjtrJL9ymmyRINKGBpwqGdQw/V0FJ9lGJvZ3mwGPfFvfQgWr/BJT/KJRcA 5xiNRQSYoPKd9OoCj208jRpEanZc80It7ojaE/b+lucBZCaYKtf2oqGiNj4qpUDk2ZS2 ZcnzPt3Rv5jujXqv8DQsIpDYQEgmt2PjErnDnm+C10S6kZMJNVdS92nCH6IA0Pn7tJIC 01WYdWJx10Q4knsaU82ps/pS79yQZF5dNU2AwnPieCKBb72X9Z1oWamqYnLsr3qRxEGf aJhLHLDwlGMcRM62Cu2Tw5FLuEz8ickycz3t+Y6UuVFfHGqmIG93tH9/+sDjHEgVvKfd J4FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ivQ+5w6gqTTydb1tqWIWXFraOTP1/upmkImTTfJeDec=; b=IZvGTnN8FOCC6CHNFYnuQ6RfTwf0c5KeaphBUF8hnR0+pC8xlK72fYnsUXb0VMkY4+ AMfIxA9HbxSQpicHNfLsvunX1/VfOY7LDpNSo2WugtNkuMbAfmfSpptZ6VwkYfldAFId E5x54SFmhCH5ATL6TbIJ+5wq3tsqipTbg3aOpyXeAo9B5/UzPiVX8Yt/Rw6WydtohLM3 ZTMsTm94U9LUua5jRoev6olD7kOz+dXh2D+AUCHaghBvyIWtvmkrdG4r+TpoQTyWEJ5b BADw6Lz8gW1JCjzNVTa6SCGodqkViztF5cDHnI3IoizXZeXGry4hyZCDr+Q3mWzGXOML t3gg== X-Gm-Message-State: AElRT7G2WM9wOqTbRs7/SoS6cZsajSJUIrT8S+g04hEWtZOXIYVmH6N+ V26K7l7k6i9IGoSkZRSRbvOczTxeWaijBpChsHM= X-Google-Smtp-Source: AG47ELvbQ31C/QxnTUcrXLcOsOiqeRpEPIDYlkNq7dj9CLsbUclbcGfDTTEh8yZ+sTsuiXaHGKPpSh7PfZDAFp4zKw8= X-Received: by 2002:a19:6d03:: with SMTP id i3-v6mr2115996lfc.34.1521067888317; Wed, 14 Mar 2018 15:51:28 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.2.195 with HTTP; Wed, 14 Mar 2018 15:51:27 -0700 (PDT) In-Reply-To: <20180314225009.gu3awgryggsxqmff@mutt-hbsd> References: <201802251429.w1PEThjY035303@repo.freebsd.org> <20180314225009.gu3awgryggsxqmff@mutt-hbsd> From: Alan Somers Date: Wed, 14 Mar 2018 16:51:27 -0600 X-Google-Sender-Auth: wzY93_gut6vTAIVG8GkPbp6e9tY Message-ID: Subject: Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys To: Shawn Webb Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 22:51:35 -0000 On Wed, Mar 14, 2018 at 4:50 PM, Shawn Webb wrote: > On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > > Author: asomers > > Date: Sun Feb 25 14:29:43 2018 > > New Revision: 329984 > > URL: https://svnweb.freebsd.org/changeset/base/329984 > > > > Log: > > Don't declare __assfail as static > > > > It gets called by dmu_buf_init_user, which is inline but not static. > So it > > needs global linkage itself. > > > > Reported by: GCC-6 > > MFC after: 17 days > > X-MFC-With: 329722 > > > > Hey Alan, > > This commit breaks compiling world with ASAN. > > Some applications, like zfs, will fail with this error: > > /lib/libuutil.so.2: Undefined symbol "__assfail" > > Thanks, > How does one build world with ASAN ?