Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Aug 2012 19:06:14 GMT
From:      Luiz Otavio O Souza <loos.br@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   kern/170931: [patch] Remove duplicated GEOM_PART_* options from MIPS kernels
Message-ID:  <201208231906.q7NJ6EfV021541@red.freebsd.org>
Resent-Message-ID: <201208231910.q7NJA0mR049531@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         170931
>Category:       kern
>Synopsis:       [patch] Remove duplicated GEOM_PART_* options from MIPS kernels
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 23 19:10:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Luiz Otavio O Souza
>Release:        -current
>Organization:
>Environment:
FreeBSD server01 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r238303: Mon Jul  9 21:47:19 BRT 2012     root@server01:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
The GEOM_PART_MBR and GEOM_PART_BSD options are already defined in sys/mips/conf/DEFAULTS so adding it to any other MIPS kernel will generate the following warning:


--------------------------------------------------------------
>How-To-Repeat:

>Fix:

The following patch is also available at: http://loos.no-ip.org/rb/duplicated-kernel-options.patch



Patch attached with submission follows:

Index: sys/mips/conf/AP96
===================================================================
--- sys/mips/conf/AP96	(revision 239611)
+++ sys/mips/conf/AP96	(working copy)
@@ -22,8 +22,6 @@
 options		AR71XX_ENV_UBOOT
 
 # For DOS - enable if required
-options 	GEOM_PART_BSD
-options 	GEOM_PART_MBR
 options 	MSDOSFS
 
 # uncompress - to boot read-only lzma natively from flash
Index: sys/mips/conf/ROUTERSTATION
===================================================================
--- sys/mips/conf/ROUTERSTATION	(revision 239611)
+++ sys/mips/conf/ROUTERSTATION	(working copy)
@@ -16,8 +16,6 @@
 options		GEOM_UZIP
 
 # For DOS
-options		GEOM_PART_BSD
-options		GEOM_PART_MBR
 options		MSDOSFS
 
 # Boot path - redboot MFS
Index: sys/mips/conf/TP-WN1043ND
===================================================================
--- sys/mips/conf/TP-WN1043ND	(revision 239611)
+++ sys/mips/conf/TP-WN1043ND	(working copy)
@@ -29,8 +29,6 @@
 
 # read MSDOS formatted disks - USB
 options		MSDOSFS
-options		GEOM_PART_BSD
-options		GEOM_PART_MBR
 
 # Enable the uboot environment stuff rather then the
 # redboot stuff.
Index: sys/mips/conf/PB92
===================================================================
--- sys/mips/conf/PB92	(revision 239611)
+++ sys/mips/conf/PB92	(working copy)
@@ -106,8 +106,6 @@
 #device		da
 
 # Read MSDOS formatted disks
-options		GEOM_PART_BSD
-options		GEOM_PART_MBR
 # options		MSDOSFS
 
 # GPIO Bus
Index: sys/mips/conf/RSPRO
===================================================================
--- sys/mips/conf/RSPRO	(revision 239611)
+++ sys/mips/conf/RSPRO	(working copy)
@@ -17,8 +17,6 @@
 options		GEOM_UZIP
 
 # For DOS
-options		GEOM_PART_BSD
-options		GEOM_PART_MBR
 options		MSDOSFS
 
 # For etherswitch support
Index: sys/mips/conf/PB47
===================================================================
--- sys/mips/conf/PB47	(revision 239611)
+++ sys/mips/conf/PB47	(working copy)
@@ -27,8 +27,6 @@
 options		AR71XX_REALMEM=64*1024*1024
 
 # For DOS - enable if required
-options		GEOM_PART_BSD
-options		GEOM_PART_MBR
 options		MSDOSFS
 
 # uncompress - to boot read-only lzma natively from flash
Index: sys/mips/conf/AP93
===================================================================
--- sys/mips/conf/AP93	(revision 239611)
+++ sys/mips/conf/AP93	(working copy)
@@ -108,8 +108,6 @@
 #device		da
 
 # Read MSDOS formatted disks
-options		GEOM_PART_BSD
-options		GEOM_PART_MBR
 #options		MSDOSFS
 
 # GPIO Bus
Index: sys/mips/conf/RSPRO_STANDALONE
===================================================================
--- sys/mips/conf/RSPRO_STANDALONE	(revision 239611)
+++ sys/mips/conf/RSPRO_STANDALONE	(working copy)
@@ -18,8 +18,6 @@
 options		GEOM_UZIP
 
 # For DOS
-options		GEOM_PART_BSD
-options		GEOM_PART_MBR
 options		MSDOSFS
 
 # .. first DOS-partitioned, BSD sliced flash disk


>Release-Note:
>Audit-Trail:
>Unformatted:
 >>> Kernel build for RSPRO started on Thu Aug 23 10:20:46 BRT 2012
 --------------------------------------------------------------
 ===> RSPRO
 mkdir -p /data/rb/rb450g/obj/mips.mips/data/rb/rb450g/src/sys
 
 --------------------------------------------------------------
 >>> stage 1: configuring the kernel
 --------------------------------------------------------------
 cd /data/rb/rb450g/src/sys/mips/conf;  PATH=/data/rb/rb450g/obj/mips.mips/data/rb/rb450g/src/tmp/legacy/usr/sbin:/data/rb/rb450g/obj/mips.mips/data/rb/rb450g/src/tmp/legacy/usr/bin:/data/rb/rb450g/obj/mips.mips/data/rb/rb450g/src/tmp/legacy/usr/games:/da ta/rb/rb450g/obj/mips.mips/data/rb/rb450g/src/tmp/usr/sbin:/data/rb/rb450g/obj/mips.mips/data/rb/rb450g/src/tmp/usr/bin:/data/rb/rb450g/obj/mips.mips/data/rb/rb450g/src/tmp/usr/games:/sbin:/bin:/usr/sbin:/usr/bin  config  -d /data/rb/rb450g/obj/mips.mips /data/rb/rb450g/src/sys/RSPRO  /data/rb/rb450g/src/sys/mips/conf/RSPRO
 WARNING: duplicate option `GEOM_PART_BSD' encountered.
 WARNING: duplicate option `GEOM_PART_MBR' encountered.
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 Kernel build directory is /data/rb/rb450g/obj/mips.mips/data/rb/rb450g/src/sys/RSPRO
 Don't forget to do ``make cleandepend && make depend''
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208231906.q7NJ6EfV021541>