From owner-freebsd-current Fri Dec 13 13:30:13 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AD6C37B401; Fri, 13 Dec 2002 13:30:11 -0800 (PST) Received: from sccrmhc03.attbi.com (sccrmhc03.attbi.com [204.127.202.63]) by mx1.FreeBSD.org (Postfix) with ESMTP id 713E843EDA; Fri, 13 Dec 2002 13:30:10 -0800 (PST) (envelope-from julian@elischer.org) Received: from InterJet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4]) by sccrmhc03.attbi.com (sccrmhc03) with ESMTP id <20021213213008003006l9u3e>; Fri, 13 Dec 2002 21:30:09 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id NAA10834; Fri, 13 Dec 2002 13:26:12 -0800 (PST) Date: Fri, 13 Dec 2002 13:26:10 -0800 (PST) From: Julian Elischer To: Dan Nelson Cc: Nate Lawson , Kevin Oberman , FreeBSD current users , re@freebsd.org Subject: Re: 5.0 showstopper In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 13 Dec 2002, Julian Elischer wrote: > > > On Fri, 13 Dec 2002, Dan Nelson wrote: > > > In the last episode (Dec 13), Julian Elischer said: > > > It's always been there. the question is > > > "Who has broken it?" > > I think this is a 5.0 showstopper. Having 5.0 overwrite your > Windows partition would be "poor" PR. > Having a quick look at it, it shouldn't be too hard for PHK > to fix it as he has all the correct parts currently "loaded" > into his head. Especially such things as making GEOM not allow writes > to -ve blocknumbers (as must have happenned for root to have been > overwritten). looking at the code in src/sys/i386/i386/dump_machdep.c, we see: 78 dumplo = di->mediaoffset + di->mediasize - Maxmem * (off_t)PAGE_SIZE; 79 dumplo -= sizeof kdh * 2; 80 i = di->dumper(di->priv, &kdh, 0, dumplo, sizeof kdh); 81 if (i) 82 printf("\nDump failed writing header (%d)\n", i); 83 dumplo += sizeof kdh; 84 i = 0; It looks like the following test should go after line 77 if (di->mediasize < ((Maxmem * (off_t)PAGE_SIZE) + (sizeof kdh * 2) + (16*1024)) { /* 16K is an arbitrary buffer * in case the swap part is * the first part */ printf("\nDump failed. Partition too small.\n"); return; } > > > > > I think it has just slowly bitrotted. I opened a PR on this in > > November. > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/45777 > > > > -- > > Dan Nelson > > dnelson@allantgroup.com > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message