From nobody Wed May 7 12:36:00 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZsvrK1TNnz5wDYt; Wed, 07 May 2025 12:36:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZsvrK03f0z3q32; Wed, 07 May 2025 12:36:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746621361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cKdjLJRPn0jwgGNgeU09MOzJQWcH9mzAg+OodokPJes=; b=Ppp/CGt9DHQXinQOXxMVEsRZDx05vuosOS3qyLhKlYlQsUdqt6ydOG+2UiT+LYcLkBreCb Q8HfrN7VLFxDaD4J8KuxIqMKKbqre+BUlncAwzoZZA+32RiqGNrVnTye+OPoI6gSE++iVB UtGAYepz71LvvIxzXf91KKcxYDk5WLadVutr44dTYXPDo5djjuPJxE2LKcAXQUWLzaWekR 5KJyFm+jSDW9GD8k5HvuesomVTlypTLTtxn0rSS0jyab2Gg3udvXiMdejDXd/9vkmcahpk OrnyWNU3IEnW3sv5sJHZkMwzgwFDAMq8vfNVm7eFGFNp+t1/mITg2hAP0+hs9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746621361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cKdjLJRPn0jwgGNgeU09MOzJQWcH9mzAg+OodokPJes=; b=OGlwnGSwqGTKT6W7YzTt21wJbRdJxRezE14u3TvUmbXVoXUXj5drDD8R01rQQ0EXPWXBL3 Ed03VziwfgwzxV/1Pdi9RkQFkeVq8cCZ5Aof3R38/Td2JUBKtFsAD717n+fwAbWFB9SXDK 3s0ed3ppApwf8vV7+AHOECcMbn1oCwKZhX/qh3JiNVWVVBIRrrulGUVPA/I/TMPcSmp9Xn G2sRTVB9jEZ4Deo5U230topmzOjHjH6DUpFsiX9GzSXvqQnxAfKoL+dyZgCi5qI2iZx0MD Ze9h8710Cwka1lOdmFlT4wrQ+iOG2ZSK/WkjwEFba1tMtiOZG0asXol7nzziSA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746621361; a=rsa-sha256; cv=none; b=na0Aq/gLEhHqnRM4TgSUnI0hZnt+886l1VpKqilIZXWeb3vXUTQtjKusZc1g8qM/AJC2Sq vgDSXnb/PQsSRdnYSewhF1W/Eh8TxexJcPoIlr04D8ZWOpw6j9wLxRHyzt1SX/+sS+q63K b9k2aLUdWtO6RPKFMdG52kYsaGxRIN7rQVNwhmzu9aS8b+U1FJ+M9VMSh/8VW75wCx1lCv IBAz6TUaeU0pmKBENVIQ867GrLQPdHhhnWisdd0q+bh7Zcfwt0dCGrOAztplQHtt0j2Fgk 54qibAIdlqjJGAv6pKu0jOHjLSnd1nfM3QCqEcNpCxaBdHiOya4eaq1MvmvjsQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZsvrJ6WzQzDN1; Wed, 07 May 2025 12:36:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 547Ca0xI073577; Wed, 7 May 2025 12:36:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 547Ca0XO073574; Wed, 7 May 2025 12:36:00 GMT (envelope-from git) Date: Wed, 7 May 2025 12:36:00 GMT Message-Id: <202505071236.547Ca0XO073574@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 0285c2428780 - main - queue(3): Add a test for STAILQ_REVERSE() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0285c2428780cdb94bfb7d2dc1806a4bd129324e Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=0285c2428780cdb94bfb7d2dc1806a4bd129324e commit 0285c2428780cdb94bfb7d2dc1806a4bd129324e Author: Olivier Certner AuthorDate: 2025-05-05 09:50:28 +0000 Commit: Olivier Certner CommitDate: 2025-05-07 12:34:39 +0000 queue(3): Add a test for STAILQ_REVERSE() Reviewed by: kib, markj MFC after: 1 week MFC with: e8286eb29516 ("sys/queue.h: add STAILQ_REVERSE") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D50165 --- tests/sys/sys/queue_test.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/tests/sys/sys/queue_test.c b/tests/sys/sys/queue_test.c index 75974ad8d792..7f8738751b85 100644 --- a/tests/sys/sys/queue_test.c +++ b/tests/sys/sys/queue_test.c @@ -165,6 +165,34 @@ ATF_TC_BODY(type ## _split_after_and_concat, tc) \ type ## _destroy(type); \ } +#define QUEUE_TESTS_CHECK_REVERSED(type, TYPE) \ +/* \ + * Checks that some tailq/list is reversed. \ + */ \ +static void \ +type ## _check_reversed(const struct type ## _ids *const type, \ + const u_int nb, const u_int id_shift) \ +{ \ + struct type ## _id_elem *e; \ + u_int i = 0; \ + \ + TYPE ## _FOREACH(e, type, ie_entry) { \ + const u_int expected_id = nb - 1 - i + id_shift; \ + \ + ATF_REQUIRE_MSG(i < nb, \ + #type " %p has more than %u elements", \ + type, nb); \ + ATF_REQUIRE_MSG(e->ie_id == expected_id, \ + #type " %p element %p, idx %u: Found ID %u, " \ + "expected %u", \ + type, e, i, e->ie_id, expected_id); \ + ++i; \ + } \ + ATF_REQUIRE_MSG(i == nb, \ + #type " %p has only %u elements, expected %u", \ + type, i, nb); \ +} + /* * Paper over the *_CONCAT() signature differences. */ @@ -216,11 +244,40 @@ ATF_TC_BODY(type ## _split_after_and_concat, tc) \ * Meat. */ +/* Common tests. */ QUEUE_TESTS_COMMON(tailq, TAILQ); QUEUE_TESTS_COMMON(list, LIST); QUEUE_TESTS_COMMON(stailq, STAILQ); QUEUE_TESTS_COMMON(slist, SLIST); +/* STAILQ_REVERSE(). */ +QUEUE_TESTS_CHECK_REVERSED(stailq, STAILQ); +ATF_TC(stailq_reverse); +ATF_TC_HEAD(stailq_reverse, tc) +{ + atf_tc_set_md_var(tc, "descr", "Test STAILQ_REVERSE"); +} +ATF_TC_BODY(stailq_reverse, tc) +{ + const u_int size = 100; + struct stailq_ids *const stailq = stailq_create(size, 0); + struct stailq_ids *const empty_stailq = stailq_create(0, 0); + const struct stailq_id_elem *last; + + stailq_check(stailq, size, 0); + STAILQ_REVERSE(stailq, stailq_id_elem, ie_entry); + stailq_check_reversed(stailq, size, 0); + last = STAILQ_LAST(stailq, stailq_id_elem, ie_entry); + ATF_REQUIRE_MSG(last->ie_id == 0, + "Last element of stailq %p has id %u, expected 0", + stailq, last->ie_id); + stailq_destroy(stailq); + + STAILQ_REVERSE(empty_stailq, stailq_id_elem, ie_entry); + stailq_check(empty_stailq, 0, 0); + stailq_destroy(empty_stailq); +} + /* * Main. */ @@ -230,6 +287,7 @@ ATF_TP_ADD_TCS(tp) QUEUE_TESTS_REGISTRATION(tp, list); QUEUE_TESTS_REGISTRATION(tp, stailq); QUEUE_TESTS_REGISTRATION(tp, slist); + ATF_TP_ADD_TC(tp, stailq_reverse); return (atf_no_error()); }