From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Jan 21 02:17:14 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6808916A4CE; Wed, 21 Jan 2004 02:17:14 -0800 (PST)
Received: from atlas.informatik.rwth-aachen.de
	(atlas.Informatik.RWTH-Aachen.DE [137.226.194.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8C9B843D49; Wed, 21 Jan 2004 02:17:11 -0800 (PST)
	(envelope-from stolz@i2.informatik.rwth-aachen.de)
Received: from menelaos.informatik.rwth-aachen.de
	(menelaos.Informatik.RWTH-Aachen.DE [137.226.194.73])
	8.11.1-0.5-michaelw-20030918) with ESMTP id i0LAH8m16934;
	Wed, 21 Jan 2004 11:17:08 +0100
Received: (from stolz@localhost)i0LAH8me016961;
	Wed, 21 Jan 2004 11:17:08 +0100 (CET)	(envelope-from stolz)
Date: Wed, 21 Jan 2004 11:17:08 +0100
From: Volker Stolz <stolz@i2.informatik.rwth-aachen.de>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Message-ID: <20040121101708.GA16862@i2.informatik.rwth-aachen.de>
References: <200401211002.i0LA2uhZ016841@menelaos.informatik.rwth-aachen.de>
	<200401211010.i0LAAHiv068190@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200401211010.i0LAAHiv068190@freefall.freebsd.org>
X-PGP-Key: finger vs@foldr.org
X-PGP-Id: 0x3FD1B6B5
User-Agent: Mutt/1.5.4i
cc: mab@red-bean.com
Subject: Re: ports/61670: [update] comm/garmin-utils 2.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jan 2004 10:17:14 -0000

> >Synopsis:       [update] comm/garmin-utils 2.0

For completeness: The comment for the Makefile.inc-patch should read
    "...appropriate for all CFLAGS",
because if you have -W in make.conf, the -Werror will be triggered.

The committer might want to consider not adding the Makefile-patch
if it's just necessary for 'obscure' CFLAGS. OTOH, I think the patch
should go in because it took me quite some time to find out why it
wouldn't build -- including a stint into the C99-standard w.r.t.
struct-initialization. Interesting to note that you only have such
insights *after* pressing 's' to submit the PR...

Volker
-- 
http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
rage against the finite state machine