From owner-svn-ports-head@freebsd.org  Mon Apr 16 12:32:04 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD643FA68C8;
 Mon, 16 Apr 2018 12:32:03 +0000 (UTC)
 (envelope-from adridg@freebsd.org)
Received: from smtp01.mail.online.nl (smtp01.mail.online.nl [194.134.25.71])
 by mx1.freebsd.org (Postfix) with ESMTP id 508B87193C;
 Mon, 16 Apr 2018 12:32:02 +0000 (UTC)
 (envelope-from adridg@freebsd.org)
Received: from a-pc.localnet (s55969a9e.adsl.online.nl [85.150.154.158])
 by smtp01.mail.online.nl (Postfix) with ESMTP id 5182540062;
 Mon, 16 Apr 2018 14:31:53 +0200 (CEST)
From: Adriaan de Groot <adridg@freebsd.org>
To: "Lev A. Serebryakov" <lev@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r467478 - in head: devel/p5-subversion
 devel/py-subversion devel/ruby-subversion devel/subversion
 devel/subversion/files java/java-subversion www/mod_dav_svn
Date: Mon, 16 Apr 2018 08:31:47 -0400
Message-ID: <22429616.yAmutGOGha@a-pc>
Organization: FreeBSD
In-Reply-To: <201804161153.w3GBr3HW062183@repo.freebsd.org>
References: <201804161153.w3GBr3HW062183@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1857805.W36H4VL4gu";
 micalg="pgp-sha256"; protocol="application/pgp-signature"
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2018 12:32:04 -0000

--nextPart1857805.W36H4VL4gu
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

Hi Lev,

On Monday, April 16, 2018 7:53:03 AM EDT Lev A. Serebryakov wrote:
> Modified: head/devel/p5-subversion/Makefile
> ============================================================================
> == --- head/devel/p5-subversion/Makefile   Mon Apr 16 11:18:24 2018       
> (r467477) +++ head/devel/p5-subversion/Makefile   Mon Apr 16 11:53:03 2018 
>       (r467478) @@ -2,7 +2,7 @@
>  # $FreeBSD$
> 
>  PKGNAMEPREFIX= p5-
> -PORTREVISION=  2
> +PORTREVISION=  0

It's a bit unusual to leave PORTREVISION in the Makefile when it's 0, isn't 
it? It doesn't really reduce churn, either, in the line-based diffs subversion 
supports.

>  MAINTAINER=    lev@FreeBSD.org
>  COMMENT=       Perl bindings for Version control system
> @@ -32,6 +32,9 @@ CONFIGURE_ARGS+=      --without-gnome-keyring \
> 
>  ALL_TARGET=    swig-pl-lib swig-pl
>  INSTALL_TARGET=        install-swig-pl
> +
> +#CPPFLAGS+=    -I${LOCALBASE}/lib/perl5/${PERL_VER}/${PERL_ARCH}/CORE \
> +#              -Isubversion/bindings/swig/proxy

It's also unusual to leave commented out bits-n-bobs from previous versions 
around; that's what subversion is for :)

[ade]

--nextPart1857805.W36H4VL4gu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iF4EABEIAAYFAlrUl7MACgkQMu5UWj4IU09kNQEAzcn9pgK5+5FqdWPWDU800OPk
npBLo7il6V+ERY24N4AA/3MWrLp3c0rZBTnqNlHB4j2dZ58YlHZNA0bqyL2GQf1l
=xA0g
-----END PGP SIGNATURE-----

--nextPart1857805.W36H4VL4gu--