From owner-freebsd-dtrace@FreeBSD.ORG Sun Jul 28 15:52:15 2013 Return-Path: Delivered-To: freebsd-dtrace@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4F4D9E34 for ; Sun, 28 Jul 2013 15:52:15 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm40-vm4.bullet.mail.gq1.yahoo.com (nm40-vm4.bullet.mail.gq1.yahoo.com [98.136.217.127]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 076ED206C for ; Sun, 28 Jul 2013 15:52:14 +0000 (UTC) Received: from [216.39.60.182] by nm40.bullet.mail.gq1.yahoo.com with NNFMP; 28 Jul 2013 15:45:53 -0000 Received: from [208.71.42.194] by tm18.bullet.mail.gq1.yahoo.com with NNFMP; 28 Jul 2013 15:45:53 -0000 Received: from [127.0.0.1] by smtp205.mail.gq1.yahoo.com with NNFMP; 28 Jul 2013 15:45:53 -0000 X-Yahoo-Newman-Id: 628406.45121.bm@smtp205.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 2EonxVcVM1mGMgrWAqRxXnIYdtWRXSQJ_EvfGwlR4Rx.osU xa5t3fdgFvgRGOIlkUagoymrBFWmeMn56rCZ22ewjYVahONS9IwgqQTWfF2B yLR7M1l95DwcEWCP9VS2V_sLCqNyyuEU0xzbSPrNUMXP.lsOdTCjgXu757V7 RMEXSBWs5HEa_eBvRGP0en_0WuchIebPNDMrWjgFEfKl7NBMorJa2dBnP_Ly kr4VFaetUWO0a21s8Pmz0b_ytm4m0tN0NeBMRkH213wpyFDMYEiVEaWWLBlF FAFROShCd.jHMAVDCPweFLe0od0tGfN05Y9bXvFIyHl0doCrfSzpos8m8IuZ TMI2q0aVYs33bCCG_ToaZhnegWAiTKV67nhLlZmvSXXtljw2zjcZcp0aMnJp LWHdVxJefi3qgAyGpDPYIsDKDCAfDxZHvIEeg5JZis9tjpZb6E2CfOXX6BLE lwObt3he0AqvsbLcbpSBDRWrzpGHOpyBqwH7R4RdbYvo89HsAbPwjzVyhUnf dwAI3vfLG6J3tbxJh7CwQlnRHltshvDj1wwZ4fRjf7kxnD07ulXu_iUzB6Jz Fh774JMukpmYgR_yjIDgfocfX9tvEPz9JCGZBtjEfgKB.pjYvERUH0.JNWZk X4nQwozRbf9FPOkXDpVtCUQHTDYT9 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.102] (pfg@190.157.126.109 with ) by smtp205.mail.gq1.yahoo.com with SMTP; 28 Jul 2013 08:45:53 -0700 PDT Message-ID: <51F53CB1.8070005@FreeBSD.org> Date: Sun, 28 Jul 2013 10:45:53 -0500 From: Pedro Giffuni Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: freebsd-dtrace@freebsd.org Subject: Re: update to dtrace disassembler References: <51F4DC5C.4010708@FreeBSD.org> In-Reply-To: <51F4DC5C.4010708@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: avg@FreeBSD.org X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2013 15:52:15 -0000 El 28/07/2013 3:54 a. m., Andriy Gapon escribió: > > Guys, > > I would like to finally commit the following change: > http://people.freebsd.org/~avg/dtrace-disassm-osol.diff > > It should bring DTrace x86 disassembler code to the latest version that was > available in OpenSolaris. My plan is to later merge any Illumos changes to this > code. > Thank you, very nice! > Could you please test and/or review this? > Also, is there any kind of mergeinfo that should make for this commit? > So that the later merges are easier to do. > > In general, what are the current practices for DTrace merges from Illumos? > I recall that the original DTrace code ported from OpenSolaris did not have any > kind of information that would correlate it to the upstream. > The only rule I know of is to copy new files from the vendor area. It is rather important to note where the change comes from so I have been using a template with the revision number and/or Illumos issue number inspired on similar commit logs for ZFS. I usually find it easier to take the references/patches from the illumos-gate bitbucket. Nope that helps, Pedro.