From owner-freebsd-current@FreeBSD.ORG Fri Oct 25 23:25:42 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9CEB67F9; Fri, 25 Oct 2013 23:25:42 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (server.infocus-llc.com [206.156.254.44]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7602229A2; Fri, 25 Oct 2013 23:25:41 +0000 (UTC) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id A5C2737B49C; Fri, 25 Oct 2013 18:25:35 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3d61dp5Zjgz21c; Fri, 25 Oct 2013 18:25:34 -0500 (CDT) Date: Fri, 25 Oct 2013 18:25:34 -0500 From: "Matthew D. Fuller" To: Diane Bruce Subject: Re: svn commit: r255715 - head/usr.bin/calendar Message-ID: <20131025232534.GQ59837@over-yonder.net> References: <201309192017.r8JKHoMj000974@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201309192017.r8JKHoMj000974@svn.freebsd.org> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.21-fullermd.4 (2010-09-15) X-Virus-Scanned: clamav-milter 0.98 at thyme.infocus-llc.com X-Virus-Status: Clean Cc: current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Oct 2013 23:25:42 -0000 On Thu, Sep 19, 2013 at 08:17:50PM +0000 I heard the voice of Diane Bruce, and lo! it spake thus: > > Log: > - calendar uses cpp internally, this diff removes this usage and > substitutes a limited subset cpp processor internally. (I'm sorta guessing at this change being the responsible one, but I feel pretty safe about it.) This gave my calendar output heartburn in two different ways. Firstly, my ~/.calendar/calendar (which I'd long since forgotten even existed; hadn't been touched since last millennium) had lines like #include which had worked fine previously, but now force-added the path to the beginning, leading to a long list of 38152 calendar NAMI "/usr/share/calendar//usr/share/calendar/calendar.birthday" in the ktrace output. It could reasonably be argued that it's coloring outside the lines a bit, but the manpage still speaks as though it should DTRT. But the major upshot was that it didn't find any actual files, and so calendar output nothing and exited without any errors or error code. That part, doesn't seem so much right; it should at least say SOMETHING, neh? But with that tracked down and changed, it now started outputting stuff. Too much stuff. Way too much stuff, in character sets my xterm didn't know what to do with. It turns out THAT was a result of lines in the file like /* #include */ which cpp properly did nothing with, but the built-in parsing still sees and processes. That's definitely buggy... -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream.