From nobody Thu Nov 21 23:12:35 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XvYsv4NmWz5dk71 for ; Thu, 21 Nov 2024 23:12:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XvYsv1yysz4PZv for ; Thu, 21 Nov 2024 23:12:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732230755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=avqSzAC3+qj6X4xd8Y0j8fHlOydMffU/iQ1SOtFyPWk=; b=xJeucAaB2h7tlLj8o8rxsvuugZLNFTzOU0aE5ls2c7KjBl9wF0SNFaGA/FFs+T5ESkR02O OdcEQjSNn1M6sYS5KsY55ShzpIMEwDyKqEG7tomoZI1+gfp868FURVYnl04sjKX4LSDv8R 1AChwWm3JmGLegWWVNvL9A9ik0DwfYLoXjBS508GamnBsCX5lLBSOg3s8hj5Jot9PJOi0S hZ/DU1v9po/rpEzwWEv3H2lb+p9EwvZxxAMK2JF+gM5vIuj5R7HyLzqKBvddc7L+0VTSuh tsR15G7yk4/zTcj9PEHhGpVLxyB248BYd/Cw13Tbnclj/hj1dqLJiAY17kttjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732230755; a=rsa-sha256; cv=none; b=p3ITPRl9tgM/eFW68gz2PtWooIpjjbulsOLzkPmRpid/pouYqaKE2P1pL3ooCq1yv03rwn MkYP5/a5PSdBcWeOpK36sFcZswCCwENRsTIHVPLjIMJj7j2Id5kbYJKwkuzdqRou9LTvLL bm0OI41D5lTTF0C8PGPUZ1ZC9rNwbPKbhf/G4r6hEIMt0rcVHbRD27OKqf4AEhFvp8m62W u3PUvGqqSi1giuDArT1WsGHfpLl1ENge72BE2IE64YhRgqkLXhrZPVitMg0wPL4VqVbBSh E/K4nhPgFniDfu6huc82d00+oY/k9HmL+6lr737PYFPfQHWQ/pNM5oLddW2hwg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XvYsv1TCBz10ZF for ; Thu, 21 Nov 2024 23:12:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4ALNCZxP010356 for ; Thu, 21 Nov 2024 23:12:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4ALNCZ5R010355 for ports-bugs@FreeBSD.org; Thu, 21 Nov 2024 23:12:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 282645] graphics/povray37: fix build with libc++ 19 Date: Thu, 21 Nov 2024 23:12:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282645 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch 2024Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dfa64477e6c3f80ff90f2e661fdd1a2c= 0de0ee8b2 commit fa64477e6c3f80ff90f2e661fdd1a2c0de0ee8b2 Author: Dimitry Andric AuthorDate: 2024-11-09 12:04:23 +0000 Commit: Dimitry Andric CommitDate: 2024-11-21 23:11:13 +0000 graphics/povray37: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes graphics/povray37 to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ ./base/configbase.h:159:19: note: in instantiation of template class 'std::basic_string' requested here 159 | inline UCS2String ASCIItoUCS2String(const char *s) | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared = here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ This can be fixed by defining `POVMSUCS2` as `char16_t` instead of `unsigned short`, `UCS2` as `char16_t` instead of `unsigned short`, and `UCS4` as `char32_t` instead of `unsigned int` in the passed-in `CPPFLAGS` variable. Also, patch up `vfe.cpp` and `vfeconf.h` to use `char16_t` and `u16string` instead of the non-standard types. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-remov= als PR: 282645 Approved by: bsd@philippost.de (maintainer) MFH: 2024Q4 (cherry picked from commit 6133473e4227abbfcf023bea6ab5eeed9c17e55b) graphics/povray37/Makefile | 3 +++ graphics/povray37/files/patch-vfe_vfe.cpp (new) | 26 +++++++++++++++++++= ++++ graphics/povray37/files/patch-vfe_vfeconf.h (new) | 19 +++++++++++++++++ 3 files changed, 48 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=