From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jun 2 13:30:05 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A9024106567E for ; Wed, 2 Jun 2010 13:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D755C8FC2D for ; Wed, 2 Jun 2010 13:30:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o52DU4HQ037138 for ; Wed, 2 Jun 2010 13:30:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o52DU44b037135; Wed, 2 Jun 2010 13:30:04 GMT (envelope-from gnats) Date: Wed, 2 Jun 2010 13:30:04 GMT Message-Id: <201006021330.o52DU44b037135@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Sunpoet Hsieh Cc: Subject: Re: ports/144673: [PATCH] graphics/libmng: fit OPTIONS format, remove contiguous blank line X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sunpoet Hsieh List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2010 13:30:05 -0000 The following reply was made to PR ports/144673; it has been noted by GNATS. From: Sunpoet Hsieh To: bug-followup@FreeBSD.org, pav@FreeBSD.org Cc: Subject: Re: ports/144673: [PATCH] graphics/libmng: fit OPTIONS format, remove contiguous blank line Date: Wed, 2 Jun 2010 21:21:02 +0800 Hi, pav@ This is not just a stylish patch. Think if we define WITH_MNG_OPTIMIZE to enable libmng's optimization flags. Variable WITH_MNG_OPTIMIZE has been passed to files/Makefile.bsd. However, WITH_MNG_OPTIMIZE will not always be "true". You may build this port with optimization enabled by setting WITH_MNG_OPTIMIZE=ANYTHING_YOU_WANT or through portconf. e.g. a "graphics/libmng : WITH_MNG_OPTIMIZE" entry in /usr/local/etc/ports.conf This options is still no-op. I made a simple test here. A simple patch of files/Makefile.bsd is attached at the end of this mail. % make WITH_MNG_OPTIMIZE=yes ===> License check disabled, port has not defined LICENSE ===> Extracting for libmng-1.0.10_2 => MD5 Checksum OK for libmng-1.0.10.tar.gz. => SHA256 Checksum OK for libmng-1.0.10.tar.gz. ===> Patching for libmng-1.0.10_2 ===> Applying FreeBSD patches for libmng-1.0.10_2 ===> libmng-1.0.10_2 depends on shared library: jpeg - found ===> libmng-1.0.10_2 depends on shared library: lcms - found ===> Configuring for libmng-1.0.10_2 ===> Building for libmng-1.0.10_2 "/usr/ports/sunpoet/libmng/files/Makefile.bsd", line 17: 2 *** Error code 1 Stop in /usr/ports/sunpoet/libmng. Thus, using WITH_MNG_OPTIMIZE directly is a bad idea. BTW, the NOPROFILE in files/Makefile.bsd should be changed to NO_PROFILE according to the following message: "/usr/share/mk/bsd.compat.mk", line 35: warning: NOPROFILE is deprecated in favour of NO_PROFILE - Sunpoet --- test.patch begins --- diff -ruN --exclude=CVS /usr/ports/graphics/libmng/files/Makefile.bsd /usr/ports/sunpoet/libmng/files/Makefile.bsd --- /usr/ports/graphics/libmng/files/Makefile.bsd 2005-10-18 12:42:30.000000000 +0800 +++ /usr/ports/sunpoet/libmng/files/Makefile.bsd 2010-06-02 21:08:22.000000000 +0800 @@ -9,9 +9,12 @@ CFLAGS+= -I${INCDIR} .if ${WITH_MNG_OPTIMIZE} == "true" +.error 1 .for f in CHUNKINITFREE OBJCLEANUP CHUNKASSIGN CHUNKREADER CFLAGS+= -DMNG_OPTIMIZE_$f .endfor +.else +.error 2 .endif INCS= libmng.h libmng_conf.h libmng_types.h --- test.patch ends ---