From owner-freebsd-current Thu Jul 4 11:29:49 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A2B237B400 for ; Thu, 4 Jul 2002 11:29:43 -0700 (PDT) Received: from mail.pcnet.com (pcnet1.pcnet.com [204.213.232.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98FD443E09 for ; Thu, 4 Jul 2002 11:29:42 -0700 (PDT) (envelope-from eischen@pcnet1.pcnet.com) Received: from localhost (eischen@localhost) by mail.pcnet.com (8.12.3/8.12.1) with ESMTP id g64ITaw4019130; Thu, 4 Jul 2002 14:29:36 -0400 (EDT) Date: Thu, 4 Jul 2002 14:29:36 -0400 (EDT) From: Daniel Eischen To: Julian Elischer Cc: Neal Fachan , Terry Lambert , Garrett Wollman , Jonathan Lemon , current@FreeBSD.ORG Subject: Re: additional queue macro In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 4 Jul 2002, Julian Elischer wrote: > there are two proposals floatingat the moment.. > > 1/ I added debugging stuff to TAILQ to help find bad usages in KSE. > Qusetion/proposal: Should I extend this to other types and add it to the > file (or not delete what is there now) I was suggesting that you add macros for debugging purposes instead of potentially changing existing behaviour. The way you've got it now is OK I guess, just as long as it somehow doesn't get enabled or changed in userland. Perhaps it would even break consumers of it in the kernel, though, too. > 2/ > We could add a new macro/method that is slightly less efficient than the > current FOREACH macros, but allows element removal. > Exisiting methods would no change. As wollman pointed out, we already assume that it is safe to remove elements using the existing macros. Adding another interface to do the same thing kinda imples that existing behaviour may change. As proposed though, the new macros would not only allow removals, but also modification of the removed element while still walking the list. These might be useful. -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message