From owner-p4-projects@FreeBSD.ORG  Tue Jan  2 17:22:29 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id EA50016A415; Tue,  2 Jan 2007 17:22:28 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 60E5416A407;
	Tue,  2 Jan 2007 17:22:28 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 0E18713C44B;
	Tue,  2 Jan 2007 17:22:27 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l02GiDlg011813;
	Tue, 2 Jan 2007 11:44:13 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Roman Divacky <rdivacky@freebsd.org>
Date: Tue, 2 Jan 2007 11:29:54 -0500
User-Agent: KMail/1.9.4
References: <200612312353.kBVNrYYY007010@repoman.freebsd.org>
In-Reply-To: <200612312353.kBVNrYYY007010@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200701021129.54537.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]);
	Tue, 02 Jan 2007 11:44:13 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2406/Tue Jan 2 06:58:55 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 112379 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jan 2007 17:22:29 -0000

On Sunday 31 December 2006 18:53, Roman Divacky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=112379
> 
> Change 112379 by rdivacky@rdivacky_witten on 2006/12/31 23:53:30
> 
> 	Implement SETALL/GETALL IPC primitives. This fixes some LTP testcases.

Are you sure it's actually working?  I thought Linux semid structure was a
different size, and GETALL and SETALL try to copyin and copyout data from
userland without doing any conversions.

> Affected files ...
> 
> .. //depot/projects/linuxolator/src/sys/compat/linux/linux_ipc.c#8 edit
> 
> Differences ...
> 
> ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_ipc.c#8 (text+ko) ====
> 
> @@ -571,9 +571,13 @@
>  		td->td_retval[0] = seminfo.semmni;
>  		return 0;			/* No need for __semctl call */
>  	case LINUX_GETALL:
> -		/* FALLTHROUGH */
> +		cmd = GETALL;
> +		semun.val = args->arg.val;
> +		break;
>  	case LINUX_SETALL:
> -		/* FALLTHROUGH */
> +		cmd = SETALL;
> +		semun.val = args->arg.val;
> +		break;
>  	default:
>  		linux_msg(td, "ipc type %d is not implemented",
>  		  args->cmd & ~LINUX_IPC_64);
> 

-- 
John Baldwin