From owner-freebsd-acpi@FreeBSD.ORG Mon May 18 17:03:23 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C14511065672 for ; Mon, 18 May 2009 17:03:23 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 0CA958FC34 for ; Mon, 18 May 2009 17:03:22 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id UAA00135; Mon, 18 May 2009 20:03:19 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <4A1194D6.5020307@freebsd.org> Date: Mon, 18 May 2009 20:03:18 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: Nate Lawson References: <49DE1F8B.2080400@earthlink.net> <49DE2E6D.5050001@icyb.net.ua> <49DE596E.2050406@earthlink.net> <49DEFF53.1040306@icyb.net.ua> <49DF7A1C.90009@root.org> <20090418043432.O34434@sola.nimnet.asn.au> <49E8D824.1000001@root.org> <20090417200726.GG3014@deviant.kiev.zoral.com.ua> <49E8E6E3.40304@root.org> <49EDFAED.4030606@icyb.net.ua> <49EE1863.1000306@root.org> <49EF15B0.10402@icyb.net.ua> <4A11870D.1030805@freebsd.org> <4A118CC1.7060507@freebsd.org> In-Reply-To: <4A118CC1.7060507@freebsd.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@freebsd.org Subject: Re: 6.x acpi powerbutton X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2009 17:03:24 -0000 on 18/05/2009 19:28 Andriy Gapon said the following: > on 18/05/2009 19:04 Andriy Gapon said the following: >> Following up on this - maybe we can just change ACPI_VPRINT to device_printf in >> acpi_button_notify_sleep? > > Oh, nonsense, this would work only for "control method" button case. > So printf needs to be in acpi_event_power_button_sleep and > acpi_event_sleep_button_sleep... > BTW, from the code in acpi_button ("ACPI_FPB", "ACPI_FSB") it seems that the original intention was to use that driver for both fixed and "control method" buttons, but in fact the fixed case is handled directly in acpi.c code. -- Andriy Gapon