From owner-dev-commits-src-main@freebsd.org Fri Sep 10 19:23:27 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 92D39661D85; Fri, 10 Sep 2021 19:23:27 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H5m4b1Dtrz3LRg; Fri, 10 Sep 2021 19:23:27 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 18AJNPGk001867 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 10 Sep 2021 12:23:25 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 18AJNPSo001866; Fri, 10 Sep 2021 12:23:25 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Fri, 10 Sep 2021 12:23:25 -0700 From: Gleb Smirnoff To: Kristof Provost , donner@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2e5ff01d0a1f - main - if_vlan: add the ALTQ support to if_vlan. Message-ID: References: <202108250804.17P84SCM025164@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202108250804.17P84SCM025164@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4H5m4b1Dtrz3LRg X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2021 19:23:27 -0000 Kristof, On Wed, Aug 25, 2021 at 08:04:28AM +0000, Kristof Provost wrote: K> commit 2e5ff01d0a1fabc757252f9c28ad5cddc98a652d K> Author: Luiz Otavio O Souza K> AuthorDate: 2021-08-21 09:41:03 +0000 K> Commit: Kristof Provost K> CommitDate: 2021-08-25 06:56:45 +0000 K> K> if_vlan: add the ALTQ support to if_vlan. K> K> Inspired by the iflib implementation, allow ALTQ to be used with if_vlan K> interfaces. K> K> Reviewed by: donner K> Obtained from: pfsense K> MFC after: 1 week K> Sponsored by: Rubicon Communications, LLC ("Netgate") K> Differential Revision: https://reviews.freebsd.org/D31647 This was the last virtual interface standing without ALTQ. ng_iface(4), tun(4) fell much earlier. I found it fundumentally wrong to add queueing to a virtual interface. A virtual interface may classify traffic, but actual queueing should happen only at the point of physical bottlneck - the NIC. Anyway, if somebody builds useful setups with such hack, let it live. Same rationale was used when adding ALTQ to other virtual interfaces. Just grumbling. -- Gleb Smirnoff