From owner-freebsd-arch@freebsd.org Wed Jul 4 04:04:00 2018 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04ACE102A8A1 for ; Wed, 4 Jul 2018 04:04:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9037F83A71 for ; Wed, 4 Jul 2018 04:03:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 5308A102A899; Wed, 4 Jul 2018 04:03:59 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B78D102A898 for ; Wed, 4 Jul 2018 04:03:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AC0AF83A6E for ; Wed, 4 Jul 2018 04:03:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x236.google.com with SMTP id t135-v6so3648245iof.7 for ; Tue, 03 Jul 2018 21:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=KupvAQ6JCEsIHhAL+Mvr79DFL2HxBlaVZ4OkIW19tp0=; b=I1YMQOmQ+H8liNKHs7Qtx4i9a2ogUHtHzM+NxB9wPQ73mCSjJ+27+Rgey9ICVf0Bcx DjGUnYoNzlkS7f8cklMPg10x0t+mCLu3c6QHambhIbxyAISKZb67uDW/FI0CsLuAiKPC m7CPZ4xG1nRK2aQcdaaoHB/A5W178eCOiMRHUUpMNguxmw73m7/oqNHXke+OjqKmuUHU 7P1ntiRKTNj4E3T9jeJQYjrIhkyTOkhQle1eoiaT7Qrp/Rne1wkrcXIGClD907kSKzam kMPfdv+Q1lEPJV5Z/+7PELzEKnKicBO3pvtSf3y+Jfm/DlkIrLJdN0RsEpDe2r1MH101 QQYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=KupvAQ6JCEsIHhAL+Mvr79DFL2HxBlaVZ4OkIW19tp0=; b=VhsJ6D9Ukf6zpQADWvu+7MBtmwMRPexDkKf/h5RtZ9UlcqE87zk+4LVzsBmSyZ73YY dtlxyGKCPdIuUEkq8KWJWfjEUqMKR5aRODTbSHV9dWCtBCd2xijjdtswy3/CLn/IfCRi n9QPCcL99Ogcgp4IjZsme83rm2Dmm1Xz2dJI2TjWQTgX5257zJE0hM8ozLlV4Qkj324G fP3p4lC0lHq3pWuwBp4+Efn8nfNd2xHcjfMu/JB2qIk9sHoEmwEkBMif74fUvl6+m2U9 l88y7Atb1lz2vANqO/1QLLmZVFGdVvWTDXH0ZwQ3HMhF4cyK4ZNuktC9ctPt7jVy2KCs psHQ== X-Gm-Message-State: APt69E3CRlUuOoNhF2K2FvZtRAXZ1lTf5ZCSYq2XNwf78okgVv7skLko UT7H9G879GTP/005RzmULRzYHOG6yYUsQOU7MAIVmg== X-Google-Smtp-Source: AAOMgpez5nwlbdFnwgmiFdy8vtrmslCYXcnhscMk8uP8z4H+Pn0dwl7vk52+rb/8U0tMT03EEOTMrPIc7+rp18wDK6M= X-Received: by 2002:a6b:d40c:: with SMTP id l12-v6mr270646iog.37.1530677037792; Tue, 03 Jul 2018 21:03:57 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:1183:0:0:0:0:0 with HTTP; Tue, 3 Jul 2018 21:03:57 -0700 (PDT) X-Originating-IP: [74.62.67.99] In-Reply-To: <201807031756.w63HuM2c039271@pdx.rh.CN85.dnsmgr.net> References: <201807031756.w63HuM2c039271@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Tue, 3 Jul 2018 22:03:57 -0600 X-Google-Sender-Auth: tBEaHlhRPpWZtOo3usrAQLetVlA Message-ID: Subject: Re: xstr, mkstr To: "Rodney W. Grimes" Cc: John Baldwin , Eitan Adler , "freebsd-arch@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 04:04:00 -0000 On Tue, Jul 3, 2018 at 11:56 AM, Rodney W. Grimes < freebsd-rwg@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > On Tue, Jul 3, 2018, 11:41 AM Rodney W. Grimes < > > freebsd-rwg@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > [ Charset UTF-8 unsupported, converting... ] > > > > On 7/3/18 8:26 AM, Warner Losh wrote: > > > > >> "As far as I can tell" needs to be a bit stronger, > > > > >> > > > > >> Agreed. But before doing work we should first make sure that the > work > > > > >> will be productive. > > > > >> > > > > > > > > > > Xstr and most are best thought of as a final pass of the old pcc > > > compiler. > > > > > This functionality moved into gcc before the egcs split back in the > > > 90s. > > > > > The compiler has done this work for two decades now. Nobody uses > it, or > > > > > needs it today. > > > > > > > > > > Unlike tip or cu, nobody at all uses these. > > > > > > > > Agreed, these tools are quite obscure and I don't think _FreeBSD_ has > > > ever > > > > used them. > > > > > > I thought someone already pointed out places in the src tree > > > that had references to them, though they may > > > > > > > You removed the SHAREDSTRINGS support in r3493 back in 1994. It's been > > unused since then. There are comments that suggest it never worked in > > FreeBSD, but that may be 2.0 and newer only. > > Removed it, not commented it out. Someone else on this thread made > statement that stuff is refering to these tools, that could not been > what I removed in r3493. > > I do see that some of what I removed in r3493 is now back as bmake > has moved to contrib/ and these strings are now there: > ./contrib/bmake/mk/prog.mk:.if defined(SHAREDSTRINGS) > ./contrib/bmake/mk/README:SHAREDSTRINGS If defined, a new .c.o rule is > used that results in shared > > Those are parts that I totally removed from > share/mk/{bsd.README,bsd.prog.mk} in r3493. > Right, it hsn't been relevant since then, and hasn't worked in the build system. the actual programs may or may not still work, since they were never updated past the K&R era level C language. There are a number of special cases I don't think they handle, including // comments. I doubt they are still useful. > The only note I see about "never worked" is that prog.mk stuff > is suppose to have issues with Parallel make, thats in the > contrib/bmake/mk/README. Where do you have a reference to > never worked in FreeBSD? > This was reimported after the original stuff was removed. I should have said unused rather than not working since it was 'not working with the build'. Warner