Date: Thu, 12 Feb 2004 17:54:35 +0000 From: Eivind Eklund <eivind@FreeBSD.org> To: Trevor Johnson <trevor@jpj.net> Cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Subject: Re: cvs commit: ports/www/firefox Makefile distinfo pkg-descr pkg-message pkg-plist ports/www/firefox/files firebird.rb firefox.rb mkdistfile mozconfig.in patch-Double.cpp patch-build_unix_run-mozilla Message-ID: <20040212175219.GE3148@FreeBSD.org> In-Reply-To: <20040212110623.A77057@blues.jpj.net> References: <200402110716.i1B7GH9D017803@repoman.freebsd.org> <xzpisidbtvn.fsf@dwp.des.no> <1076508074.88428.14.camel@pav.hide.vol.cz> <20040211122704.X93022@blues.jpj.net> <xzpk72tiah1.fsf@dwp.des.no> <20040211165940.Q98525@blues.jpj.net> <xzp4qtweqlf.fsf@dwp.des.no> <20040212031228.E31447@blues.jpj.net> <20040212102842.GC3148@FreeBSD.org> <20040212110623.A77057@blues.jpj.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Please take the below as an attempt at being constructive and actually keeping the discussion on subject. It is somewhat directly formulated as I don't have time to do much more editing to make it more calm. On Thu, Feb 12, 2004 at 11:13:25AM -0500, Trevor Johnson wrote: > > My opinion is that DES is right anyway. This lowers the consistency of > > the ports tree overall, > > Not really--many other ports do the same thing. The fact that there are ports other places that have not been updated to use REINPLACE_CMD is not a reason for introducing a new one. And I would hope the other ports are moving *away* from using perl also for replacements, not towards it. The set of people using <= 4.6 was larger earlier, and they were less out of date earlier, and thus more reasonable to do hacks for. [Text deleted in an attempt to keep this as much on subject as possible.] > If someone (you?) have ideas about removing the Perl dependency, that > would be a really stunning enhancement to the port. As I said it's > been a huge bugbear. I don't have enough disk space to even extract it available at the moment; I may look at it again later (perhaps even tonight.) However, this is a straw man. The relevant issues (as far as I can tell) are: - The replacement of REINPLACE_CMD with PERL -pi is an efficiency hack. - The efficiency hack increase efficiency on systems of 4.6-vintage and below. It does this at the expense of consistency with our conventions, and potentially efficiency on systems newer than 4.6 (due to larger executable, more shared libs for perl, etc). Whether increasing efficiency for <=4.6 even has value *when seen completely apart from the other issues* has been questioned. - A noticable number of people have said that we value consistency in the ports tree, and that the change should be reverted. This is enough to normally trigger a re-evaluation of what is being done. - There have been no attempt from your side to argue what level of value is present in the perl changes, beyond saying they remove a dependency on <= 4.6. Eivind.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040212175219.GE3148>