From owner-freebsd-bugs@FreeBSD.ORG Sat Apr 19 18:10:00 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C0EDC695 for ; Sat, 19 Apr 2014 18:10:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9DA811D66 for ; Sat, 19 Apr 2014 18:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s3JIA0WH023866 for ; Sat, 19 Apr 2014 18:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s3JIA02i023864; Sat, 19 Apr 2014 18:10:00 GMT (envelope-from gnats) Resent-Date: Sat, 19 Apr 2014 18:10:00 GMT Resent-Message-Id: <201404191810.s3JIA02i023864@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jason Bacon Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0540A54A for ; Sat, 19 Apr 2014 18:00:43 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E69311CD9 for ; Sat, 19 Apr 2014 18:00:42 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s3JI0gb3063490 for ; Sat, 19 Apr 2014 18:00:42 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s3JI0gAG063484; Sat, 19 Apr 2014 18:00:42 GMT (envelope-from nobody) Message-Id: <201404191800.s3JI0gAG063484@cgiserv.freebsd.org> Date: Sat, 19 Apr 2014 18:00:42 GMT From: Jason Bacon To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: misc/188799: print/xfce4-print does not build when CUPS support is enaled X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Apr 2014 18:10:00 -0000 >Number: 188799 >Category: misc >Synopsis: print/xfce4-print does not build when CUPS support is enaled >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Apr 19 18:10:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Jason Bacon >Release: 10.0-RELEASE >Organization: Acadix Consulting, LLC >Environment: FreeBSD freebie.acadix.biz 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Build fails due to direct use of ipp_t fields in cups.c, which is no longer supported. >How-To-Repeat: make config select CUPS make >Fix: cups.c needs to be edited to use accessor functions instead of referencing ipp_t fields directly. Partial patch to demonstrate the approach: --- printing-systems/cups/cups.c.orig 2014-04-19 12:20:18.000000000 -0500 +++ printing-systems/cups/cups.c 2014-04-19 12:27:02.000000000 -0500 @@ -133,8 +133,10 @@ language = cupsLangDefault (); request = ippNew (); - request->request.op.operation_id = operation_id; - request->request.op.request_id = 1; + //request->request.op.operation_id = operation_id; + ippSetOperation(request,operation_id); + //request->request.op.request_id = 1; + ippSetRequestId(request,1); ippAddString (request, IPP_TAG_OPERATION, IPP_TAG_CHARSET, "attributes-charset", NULL, "utf-8"); @@ -242,7 +244,7 @@ if (!request) continue; - if (request->state == IPP_ERROR || request->state == IPP_IDLE) { + if (ippGetState(request) == IPP_ERROR || request->state == IPP_IDLE) { ippDelete (request); continue; } Not all the fixes appear to be so straightforward and I don't have time to work on it at the moment. >Release-Note: >Audit-Trail: >Unformatted: