From owner-freebsd-scsi@FreeBSD.ORG  Tue Aug 14 15:30:52 2012
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 32FBB106564A
	for <freebsd-scsi@freebsd.org>; Tue, 14 Aug 2012 15:30:52 +0000 (UTC)
	(envelope-from mitya@cabletv.dp.ua)
Received: from mail.cabletv.dp.ua (mail.cabletv.dp.ua [193.34.20.8])
	by mx1.freebsd.org (Postfix) with ESMTP id E1C318FC12
	for <freebsd-scsi@freebsd.org>; Tue, 14 Aug 2012 15:30:51 +0000 (UTC)
Received: from [193.34.20.2] (helo=m18.cabletv.dp.ua)
	by mail.cabletv.dp.ua with esmtp (Exim 4.72 (FreeBSD))
	(envelope-from <mitya@cabletv.dp.ua>) id 1T1IqZ-000MvT-Jb
	for freebsd-scsi@freebsd.org; Tue, 14 Aug 2012 18:15:55 +0300
Message-ID: <502A6351.8000904@cabletv.dp.ua>
Date: Tue, 14 Aug 2012 17:40:17 +0300
From: Mitya <mitya@cabletv.dp.ua>
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:12.0) Gecko/20120425 Thunderbird/12.0
MIME-Version: 1.0
To: freebsd-scsi@freebsd.org
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: variable generation in struct periph_driver
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Aug 2012 15:30:52 -0000

Hi. I found some logical inconsistency in file cam_periph.c in function 
cam_periph_alloc()

         if (cur_periph != NULL) {
                 KASSERT(cur_periph->unit_number != periph->unit_number, 
("duplic
ate units on periph list"));
                 TAILQ_INSERT_BEFORE(cur_periph, periph, unit_links);
         } else {
                 TAILQ_INSERT_TAIL(&(*p_drv)->units, periph, unit_links);
                 (*p_drv)->generation++;
         }

Why variable "generation" increments only in second condition ?