From owner-svn-src-all@freebsd.org Wed Feb 7 10:47:23 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67FF7EF2582 for ; Wed, 7 Feb 2018 10:47:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EC1FF82A2F for ; Wed, 7 Feb 2018 10:47:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x243.google.com with SMTP id 196so1693599iti.5 for ; Wed, 07 Feb 2018 02:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=8faVEyg3ZViy8wi4MlH5WwATEPObQksVh6aPOiuQ09M=; b=FRslOI6AxXcjf/cWIF+2b8mSrOXkL+rHUAitoX90ht1zum1mbTu+IfsPfUjPtWr5FR Q1nj53dQJv7uCHUW8W9OhNAQxQSans41Hw978O8t5QPvumRdl73Lqhs7xm2rNldQ+VDj jb7xqTwOQvQWOygbZi3B5SeNH9rQXYohg135cDLNwdlPB2wvlSSrWYEWgyxL675gc+2c 0hOGF1aAKAE6Mk6OuAOqS5nHmDrlD0BHuuFFuHfuBDxnD+ITyiwcPEHjek6BJxpJj67O jBdaamqSMhdqXFoW4Wesm0ByKe0CQhGA3hft9lXYXpRsxqpM4+s4pmvvkXnL1pQshCqs u5zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=8faVEyg3ZViy8wi4MlH5WwATEPObQksVh6aPOiuQ09M=; b=oHR4/qgN914R6ictog0mwyLOZoRxx1y/IPDu84vXnwgH8rmU8KT6jpsmhmj2FDMYtE 5RpEX6jCnb1LQLIj+M66K5byWrMOyC5VAM1j7JNmunX0gdvmtZ5sEJb0FCxPpsCyoeGk wMUf/ZD7xzJlIQKGFx74l7v68hwrUkuA8J97VKGv1LiZEbTeic5TXfzgJsgegM5PUrl2 OYx/xo7g77MSded11GJ8yel6HrWsjSYTzpvMTOVtCKw53k6nD/M62NHu1rMmZ8fWVsZ2 UejQPq21z81sz1SnIdPiFiUSN4SugFAfzgdsqHLjXNvqDzreRw/DQ7nlzb/0+dWwXqN8 OyrA== X-Gm-Message-State: APf1xPCXPnXUtruHFl9yEdYVv60YLyoFina4LoIvLLab4DxlO0PcrlBl AF2cVnHJVI+eKQfsrBpnuy9xemafMm5/YccwQiYTZA== X-Google-Smtp-Source: AH8x226DF42b3GFq4H5psOt5dZ/5E5KSDpgb/0rlvA4rcmPESJOAwOzTaGci/ZrW+xWlKKFhIkH12d2XJhj3DkgX1Ug= X-Received: by 10.36.68.206 with SMTP id o197mr7357358ita.97.1518000442098; Wed, 07 Feb 2018 02:47:22 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Wed, 7 Feb 2018 02:47:21 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:c81d:c97b:c7cd:ac64] Received: by 10.79.201.67 with HTTP; Wed, 7 Feb 2018 02:47:21 -0800 (PST) In-Reply-To: References: <201802061541.w16FfadO041469@repo.freebsd.org> <201802061925.w16JP4aq017961@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Wed, 7 Feb 2018 03:47:21 -0700 X-Google-Sender-Auth: -GbJn6uikVwKMBkqVnjt3kzs964 Message-ID: Subject: Re: svn commit: r328934 - in head: . bin/sh To: Alex Richardson Cc: "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 10:47:23 -0000 On Feb 7, 2018 2:35 AM, "Alexander Richardson" wrote: On 6 February 2018 at 19:25, Rodney W. Grimes wrote: >> Author: arichardson >> Date: Tue Feb 6 15:41:35 2018 >> New Revision: 328934 >> URL: https://svnweb.freebsd.org/changeset/base/328934 >> >> Log: >> Don't hardcode /usr/bin as the path for mktemp in build tools >> >> It won't work e.g. when crossbuilding from Ubuntu Linux as mktemp is in >> /bin there. >> >> Reviewed By: bdrewery >> Approved By: jhb (mentor) >> Differential Revision: https://reviews.freebsd.org/D13937 > > Would it be better to create the variable MKTEMP to point at > either /bin/mktemp or /usr/bin/mktemp dependent on platform, > there are reasons we use full paths in Makefiles, mostly to > stop /usr/local/bin/foo contimaton, which I believe this > change now opens up, though very slight as I dont know of > a third party mktemp binary. > I'm happy to have a mktemp variable instead, but I don't believe files in /usr/local/bin are a problem. When in add an echo $PATH to the mktokens.sh file I get the following output: PATH=/home/alr48/obj/build/freebsd-mips-build/exports/ users/alr48/sources/freebsd-mips/mips.mips64/tmp/legacy/ usr/sbin:/home/alr48/obj/build/freebsd-mips-build/ exports/users/alr48/sources/freebsd-mips/mips.mips64/tmp/ legacy/usr/bin:/home/alr48/obj/build/freebsd-mips-build/ exports/users/alr48/sources/freebsd-mips/mips.mips64/tmp/ legacy/bin:/home/alr48/obj/build/freebsd-mips-build/ exports/users/alr48/sources/freebsd-mips/mips.mips64/tmp/ usr/sbin:/home/alr48/obj/build/freebsd-mips-build/ exports/users/alr48/sources/freebsd-mips/mips.mips64/tmp/ usr/bin:/sbin:/bin:/usr/sbin:/usr/bin This only contains WORLDTMP and /sbin:/bin:/usr/sbin:/usr/bin since the toplevel makefile already sets PATH to /sbin:/bin:/usr/sbin:/usr/bin. I honestly wouldn't add a variable. It makes it more complicated for zero benefit. Unless a reasonable use case can be shown, it just flutters up the build for no benefit. Warner