From owner-freebsd-bugs Thu Jul 11 19:50:12 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E67D37B400 for ; Thu, 11 Jul 2002 19:50:02 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 60C5C43E64 for ; Thu, 11 Jul 2002 19:50:01 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6C2o1JU069786 for ; Thu, 11 Jul 2002 19:50:01 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6C2o1QH069785; Thu, 11 Jul 2002 19:50:01 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F88A37B401 for ; Thu, 11 Jul 2002 19:41:42 -0700 (PDT) Received: from smtp.noos.fr (descartes.noos.net [212.198.2.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C73A43E6A for ; Thu, 11 Jul 2002 19:41:40 -0700 (PDT) (envelope-from root@gits.dyndns.org) Received: (qmail 50376685 invoked by uid 0); 12 Jul 2002 02:41:38 -0000 Received: from unknown (HELO gits.gits.dyndns.org) ([212.198.229.153]) (envelope-sender ) by 212.198.2.74 (qmail-ldap-1.03) with SMTP for ; 12 Jul 2002 02:41:38 -0000 Received: from gits.gits.dyndns.org (njmjj5bclu8zqmm6@localhost [127.0.0.1]) by gits.gits.dyndns.org (8.12.5/8.12.5) with ESMTP id g6C2fbTL027439; Fri, 12 Jul 2002 04:41:38 +0200 (CEST) (envelope-from root@gits.dyndns.org) Received: (from root@localhost) by gits.gits.dyndns.org (8.12.5/8.12.5/Submit) id g6C2fbF3027438; Fri, 12 Jul 2002 04:41:37 +0200 (CEST) (envelope-from root) Message-Id: <200207120241.g6C2fbF3027438@gits.gits.dyndns.org> Date: Fri, 12 Jul 2002 04:41:37 +0200 (CEST) From: Cyrille Lefevre Reply-To: Cyrille Lefevre To: FreeBSD-gnats-submit@FreeBSD.org Cc: Murray Stokely X-Send-Pr-Version: 3.113 Subject: bin/40466: pax may not handle correctly some tar archives Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 40466 >Category: bin >Synopsis: pax may not handle correctly some tar archives >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jul 11 19:50:00 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Cyrille Lefevre >Release: FreeBSD 4.6-STABLE i386 >Organization: ACME >Environment: System: FreeBSD gits 4.6-STABLE FreeBSD 4.6-STABLE #16: Sat Jul 6 19:06:54 CEST 2002 root@gits:/disk2/freebsd/stable/src/sys/compile/CUSTOM i386 >Description: On Tue, Jun 11, 2002 at 05:07:42PM -0700, Murray Stokely wrote: > Sorry, I think its too late at this point. > > On Wed, Jun 12, 2002 at 01:56:09AM +0200, Cyrille Lefevre wrote: > > here is a last minute fix concerning pax, maybe it's not too late > > to integrate it in 4.6 -release ? > > > On Jun 7, 2002 01:27:31 pm +0200, Cyrille Lefevre wrote: > > > On Fri, Jun 07, 2002 at 02:15:09AM -0400, Trevor Johnson wrote: > > > > Dan Nelson wrote: > > > [snip] > > > > According to Mr. Schilling's testing, GNU tar 1.13.25 has a bug: > > > > ftp://ftp.fokus.gmd.de/pub/unix/star/testscripts/README.gtarfail . I guess > > > > it qualifies as a "non-trivial program". :-) > > > > > > FYI, the current pax implementation is able to handle the following > > > archives from ftp://ftp.fokus.gmd.de/pub/unix/star/testscripts/ : > > > > > > 100char_longlink.tar > > > gtarfail.tar > > > gtarfail2.tar > > > > > > but miserably fail on this one : > > > > > > long.ustar.gz > > > > > > $ uname -a > > > FreeBSD gits 4.6-RC FreeBSD 4.6-RC #7: Sun Jun 2 16:33:05 CEST 2002 root@gits:/disk2/4.x-stable/src/sys/compile/CUSTOM i386 > > > $ pax -zvf > > > -rw-r--r-- 1 486 cvs 4 Apr 19 2000 ___________________ > > > ___________________________________________________________________________D_099 > > > /_______________________________________________________________________________ > > > __________________1000000644 0000746 0003720 00000000004 07077317140 0055507 0 > > > > > > $ star -zvtf > > > 4 -rw-r--r-- jes/cats Apr 19 13:54 2000 __________________________________ > > > ____________________________________________________________D_099/______________ > > > ________________________________________________________________________________ > > > ___100 > > > > > > I'll try to fix this... > > > > done, here is the patch which may be integrated to 4.6 -release ? >How-To-Repeat: see above. >Fix: Index: /tmp/src/bin/pax/tar.c =================================================================== RCS file: /home/ncvs/src/bin/pax/tar.c,v retrieving revision 1.19 diff -u -r1.19 tar.c --- /tmp/src/bin/pax/tar.c 16 May 2002 01:57:13 -0000 1.19 +++ /tmp/src/bin/pax/tar.c 11 Jun 2002 23:39:16 -0000 @@ -758,7 +758,7 @@ *dest++ = '/'; cnt++; } - arcn->nlen = cnt + l_strncpy(dest, hd->name, sizeof(arcn->name) - cnt); + arcn->nlen = cnt + l_strncpy(dest, hd->name, MIN(TNMSZ + 1, sizeof(arcn->name) - cnt) - 1); arcn->name[arcn->nlen] = '\0'; /* >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message