From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 5 09:10:10 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5AF71065675 for ; Wed, 5 Aug 2009 09:10:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A13638FC16 for ; Wed, 5 Aug 2009 09:10:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n759AAZh097581 for ; Wed, 5 Aug 2009 09:10:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n759AAnf097575; Wed, 5 Aug 2009 09:10:10 GMT (envelope-from gnats) Resent-Date: Wed, 5 Aug 2009 09:10:10 GMT Resent-Message-Id: <200908050910.n759AAnf097575@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Earl Gay Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA41B106564A for ; Wed, 5 Aug 2009 09:06:34 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 98AF88FC18 for ; Wed, 5 Aug 2009 09:06:34 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7596YB8026363 for ; Wed, 5 Aug 2009 09:06:34 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n7596YwZ026362; Wed, 5 Aug 2009 09:06:34 GMT (envelope-from nobody) Message-Id: <200908050906.n7596YwZ026362@www.freebsd.org> Date: Wed, 5 Aug 2009 09:06:34 GMT From: Earl Gay To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/137454: [patch] math/p5-Math-GSL: Fix issue with finding headers X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2009 09:10:11 -0000 >Number: 137454 >Category: ports >Synopsis: [patch] math/p5-Math-GSL: Fix issue with finding headers >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Aug 05 09:10:10 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Earl Gay >Release: 7.2 >Organization: >Environment: FreeBSD fbsdvm.eeg3.net 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May 1 08:49:13 UTC 2009 root@walker.cse.buffalo.edu:/usr/obj/src/sys/GENERIC i386 >Description: The build fails due to a bug in inc/GSLBuilder.pm that adds broken arguments when building the module. It's essentially passing "-I -I/usr/local/lib/perl5/5.8.9/mach/CORE/", since there is an extra -I it doesn't actually pass the needed include path. The reason it is adding the extra -I is because there is a check to see if an array is defined, and if so it wants to add all of the elements to the include path list. The problem is that the array is always defined but it may just contain one blank element. The included patch checks to see if that element is empty and makes adjustments accordingly. I've tested the patch to fix the issue on 7.2-RELEASE(i386) and 8.0-BETA2(i386). >How-To-Repeat: >Fix: Copy the attached patch to: files/patch-inc-GSLBuilder.pm Patch attached with submission follows: --- inc/GSLBuilder.pm 2009-05-20 02:50:44.000000000 -0400 +++ inc/GSLBuilder.pm 2009-08-04 20:15:57.000000000 -0400 @@ -154,7 +154,7 @@ $cf->{installarchlib} = $Config{archlib}; - my @include_dirs = @{$p->{include_dirs}} + my @include_dirs = ( @{$p->{include_dirs}} && ( ${@{$p->{include_dirs}}}[0] ne "" ) ) ? map {"-I$_"} (@{$p->{include_dirs}}, catdir($cf->{installarchlib}, 'CORE')) : map {"-I$_"} ( catdir($cf->{installarchlib}, 'CORE') ) ; >Release-Note: >Audit-Trail: >Unformatted: