From owner-svn-src-head@freebsd.org  Wed May  9 17:15:55 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49471FC5C74;
 Wed,  9 May 2018 17:15:55 +0000 (UTC)
 (envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
 by mx1.freebsd.org (Postfix) with ESMTP id D32EB773A2;
 Wed,  9 May 2018 17:15:54 +0000 (UTC)
 (envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.55.3])
 by phk.freebsd.dk (Postfix) with ESMTP id DE14114882;
 Wed,  9 May 2018 17:09:57 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
 by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id w49H9uOS027447
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 9 May 2018 17:09:56 GMT (envelope-from phk@critter.freebsd.dk)
Received: (from phk@localhost)
 by critter.freebsd.dk (8.15.2/8.15.2/Submit) id w49H9u28027446;
 Wed, 9 May 2018 17:09:56 GMT (envelope-from phk)
To: John Baldwin <jhb@freebsd.org>
cc: Cy Schubert <cy@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r333393 - head/sys/contrib/ipfilter/netinet
In-reply-to: <4065288.o9QKfFzp22@ralph.baldwin.cx>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
References: <201805090207.w49279t8006603@repo.freebsd.org>
 <4065288.o9QKfFzp22@ralph.baldwin.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27444.1525885796.1@critter.freebsd.dk>
Date: Wed, 09 May 2018 17:09:56 +0000
Message-ID: <27445.1525885796@critter.freebsd.dk>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 May 2018 17:15:55 -0000

--------
In message <4065288.o9QKfFzp22@ralph.baldwin.cx>, John Baldwin writes:

>Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there are
>three other instances of that style in ipfilter already (and none others
>using this comment style).

Not to mention that code analysis tools like lint, FlexeLint, Coverity etc
expect /* FALLTHROUGH */ comments.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.