Date: Wed, 09 May 2018 17:09:56 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: John Baldwin <jhb@freebsd.org> Cc: Cy Schubert <cy@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333393 - head/sys/contrib/ipfilter/netinet Message-ID: <27445.1525885796@critter.freebsd.dk> In-Reply-To: <4065288.o9QKfFzp22@ralph.baldwin.cx> References: <201805090207.w49279t8006603@repo.freebsd.org> <4065288.o9QKfFzp22@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
-------- In message <4065288.o9QKfFzp22@ralph.baldwin.cx>, John Baldwin writes: >Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there are >three other instances of that style in ipfilter already (and none others >using this comment style). Not to mention that code analysis tools like lint, FlexeLint, Coverity etc expect /* FALLTHROUGH */ comments. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?27445.1525885796>