From owner-svn-src-head@freebsd.org Fri Jan 3 17:26:37 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 16E281F60AC; Fri, 3 Jan 2020 17:26:37 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47qBf36bz0z44r4; Fri, 3 Jan 2020 17:26:35 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id EE9243C0199; Fri, 3 Jan 2020 17:26:34 +0000 (UTC) Date: Fri, 3 Jan 2020 17:26:34 +0000 From: Brooks Davis To: Alexander Motin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356108 - head/sys/geom/vinum Message-ID: <20200103172634.GI91104@spindle.one-eyed-alien.net> References: <201912270136.xBR1aruf065831@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA" Content-Disposition: inline In-Reply-To: <201912270136.xBR1aruf065831@repo.freebsd.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 47qBf36bz0z44r4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-6.52 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-3.62)[ip: (-9.48), ipnet: 199.48.128.0/22(-4.73), asn: 36236(-3.84), country: US(-0.05)]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2020 17:26:37 -0000 --neYutvxvOLaeuPCA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 27, 2019 at 01:36:53AM +0000, Alexander Motin wrote: > Author: mav > Date: Fri Dec 27 01:36:53 2019 > New Revision: 356108 > URL: https://svnweb.freebsd.org/changeset/base/356108 >=20 > Log: > Reimplement gvinum orphanization. > =20 > gvinum was the only GEOM class, using consumer nstart/nend fields. Maki= ng > it do its own accounting for orphanization purposes allows in perspecti= ve > to remove burden of that expensive for SMP accounting from GEOM. > =20 > Also the previous implementation spinned in a tight event loop, waiting > for all active BIOs to complete, while the new one knows exactly when it > is possible to close the consumer. Do you know if there are other cases of gvinum being a weird GEOM class? If it's going to require more rounds of major refactoring, maybe we should look into deprecating it for 14. -- Brooks --neYutvxvOLaeuPCA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJeD3lKAAoJEKzQXbSebgfAkyIH/0kUhBfE23sEEd+7NGkySTTX xBKK+WqgMLVUb6AUscJjbxTbbUAaYPL1c1tmJKIvWvEbdHAzOlwV9H+ySprAeCkS w24vHYKfTtEg2z0aClFk6S8UPM1xMMXle6jwkjgkGQamsO+NmU8i0/bGktvZrojW 3+6/sZ3hxxLuIZhXg+OTF//AambbH5+4JOsaFuup0RD/AlQnt3XlVGxtl2MMsKyd JKZAfIOe7a8nkHH9KqhgtYqdhAb90aTKaUS7duiQ/ghyPGx4KooNSJEvxkGBQUz+ LoY452pB0p517vVMx2eDE54aEHw/lz3KFXQ+juCF3+J+x8WzcRVUtZJK26Ej6ZY= =KiDG -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA--