From owner-freebsd-current@freebsd.org Fri Jul 15 18:38:54 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE61BB99FF0; Fri, 15 Jul 2016 18:38:54 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [IPv6:2001:470:1f0f:3ad:223:7dff:fe9e:6e8a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "thebighonker.lerctr.org", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E62AF1596; Fri, 15 Jul 2016 18:38:53 +0000 (UTC) (envelope-from ler@lerctr.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=lerami; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7FS+t8K3bl7Ag5b5C1H/SfbBjM2qksyrPNgjyeFJqt0=; b=b1k1s3a3ZACqHAxTOE/kfupedf AZ2aKwh2kLEBeYNJVrG6Rii6RKQR2/iB3sF4fEL4PwgGWBnOEYsPzz3kjLJHgdwxyBdF3H4E88st8 2JXbeK0euLHrnWM3rwl1iu7pWjULq7DWhz9YR7rld0CdS2H5OIhoOrpOGd9wyPgPW2Ho=; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:223:7dff:fe9e:6e8a]:61910 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87 (FreeBSD)) (envelope-from ) id 1bO80i-00068z-La; Fri, 15 Jul 2016 13:38:52 -0500 Received: from proxy.na.alcatel-lucent.com ([135.245.48.73]) by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Fri, 15 Jul 2016 13:38:52 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 15 Jul 2016 13:38:52 -0500 From: Larry Rosenman To: Matthew Macy Cc: Gleb Smirnoff , Hans Petter Selasky , freebsd-current@freebsd.org, freebsd-net@freebsd.org, owner-freebsd-current@freebsd.org Subject: Re: callout_drain either broken or man page needs updating In-Reply-To: <155efd6dec6.1184b7a2546701.470842708059763905@nextbsd.org> References: <155eca8bae0.d811ff9b567670.7363072028299444677@nextbsd.org> <087a20a1-2b8b-2050-c75f-78aac964b457@selasky.org> <155ecfa7c59.b552d7c5570767.4742594321655958557@nextbsd.org> <20160715084303.GD1076@FreeBSD.org> <155efd6dec6.1184b7a2546701.470842708059763905@nextbsd.org> Message-ID: <385925d91a2967587dacd2fe29d5a075@thebighonker.lerctr.org> X-Sender: ler@lerctr.org User-Agent: Roundcube Webmail/1.2.0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 18:38:55 -0000 On 2016-07-15 13:34, Matthew Macy wrote: > ---- On Fri, 15 Jul 2016 01:43:03 -0700 Gleb Smirnoff > wrote ---- > > On Thu, Jul 14, 2016 at 10:14:46PM -0700, Matthew Macy wrote: > > M> > On 07/15/16 05:45, Matthew Macy wrote: > > M> > > glebius last commit needs some further re-work. > > M> > > > M> > Glebius commit needs to be backed out, at least the API change > that > > M> > changes the return value when calling callout_stop() when the > callout is > > M> > scheduled and being serviced. Simply because there is code > out there, > > M> > like Mattew and others have discovered that is "refcounting" > on the > > M> > callout_reset() and expecting that a subsequent callout_stop() > will > > M> > return 1 to "unref". > > M> > > M> Yes. This is the cause of the "refcnt 0 on LLE at boot..." > regression. > > I misread his comment on the reason for the failure. But, the failure > is caused by a regression in callout_stop. > > > No it isn't. The regression is caused by unintentional change of > return > > value for never scheduled callout. The fix is now being tested, see > PR 210884. > > Thanks. Let me know when I can update. > -M > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org" URL: https://svnweb.freebsd.org/changeset/base/302894 has the fix in HEAD. (It's a one-liner). -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281