From owner-freebsd-hackers@FreeBSD.ORG  Fri Apr 11 05:23:10 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 89451106564A;
	Fri, 11 Apr 2008 05:23:10 +0000 (UTC) (envelope-from sat@cenkes.org)
Received: from heka.cenkes.org (heka.cenkes.org [208.79.80.110])
	by mx1.freebsd.org (Postfix) with ESMTP id 690108FC18;
	Fri, 11 Apr 2008 05:23:10 +0000 (UTC) (envelope-from sat@cenkes.org)
Received: from amilo.cenkes.org (ppp85-140-149-151.pppoe.mtu-net.ru
	[85.140.149.151]) (Authenticated sender: sat)
	by heka.cenkes.org (Postfix) with ESMTPSA id A0099242F886;
	Fri, 11 Apr 2008 09:23:08 +0400 (MSD)
Date: Fri, 11 Apr 2008 09:23:06 +0400
From: Andrew Pantyukhin <infofarmer@freebsd.org>
To: Tim Kientzle <kientzle@freebsd.org>
Message-ID: <20080411052305.GE81939@amilo.cenkes.org>
References: <20080410192552.GC81939@amilo.cenkes.org>
	<47FEF166.6060606@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47FEF166.6060606@freebsd.org>
X-OS: FreeBSD 8.0-CURRENT amd64
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: hackers@freebsd.org
Subject: Re: mtree acl [patch]
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: infofarmer@FreeBSD.org
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Apr 2008 05:23:10 -0000

On Thu, Apr 10, 2008 at 10:04:38PM -0700, Tim Kientzle wrote:
> Andrew Pantyukhin wrote:
>> ... ACL support in our mtree ...
>> Also here: http://heka.cenkes.org/sat/diffs/mtree_acl.diff
> 
> Could you give an example of a short mtree file that includes ACLs?
> 
> I see a few minor style issues (tag names should be sorted on
> the mtree.5 and mtree.8 man pages, you need to correct a comment
> that got duplicated in mtree.h), but the idea looks right.

Thanks for taking a look, I corrected the things you pointed out.

Here, the parent dir and "file" have ACLs, "kk" doesn't. I
considered "acl=none" for ACL-less files, but I think it'll
produce more problems than use cases.

#	   user: sat
#	machine: amilo.cenkes.org
#	   tree: /usr/home/sat/bsdevel/src/usr.sbin/mtree/tt
#	   date: Fri Apr 11 09:12:43 2008

# .
/set type=file
.               type=dir \
                acl=user::rwx,user:root:rwx,group::r-x,mask::rwx,other::r-x
    file        acl=user::rw-,group::r--,group:wheel:rwx,mask::rwx,other::r--
    kk          acl=user::rw-,group::r--,other::r--
..