From owner-p4-projects@FreeBSD.ORG  Thu Dec  7 11:04:41 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 91B4B16A4FF; Thu,  7 Dec 2006 11:04:41 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4A95616A4FC;
	Thu,  7 Dec 2006 11:04:41 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3515243DC3;
	Thu,  7 Dec 2006 11:01:46 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.13.4/8.13.3) with ESMTP id kB7B2Pf7080985
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 7 Dec 2006 14:02:26 +0300 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.13.4/8.13.1/Submit) id kB7B2P1W080984;
	Thu, 7 Dec 2006 14:02:25 +0300 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Thu, 7 Dec 2006 14:02:25 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Paolo Pisati <piso@FreeBSD.org>
Message-ID: <20061207110225.GU32700@FreeBSD.org>
References: <200612062319.kB6NJgsq031755@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200612062319.kB6NJgsq031755@repoman.freebsd.org>
User-Agent: Mutt/1.5.6i
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 111230 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Dec 2006 11:04:41 -0000

On Wed, Dec 06, 2006 at 11:19:42PM +0000, Paolo Pisati wrote:
P> http://perforce.freebsd.org/chv.cgi?CH=111230
P> 
P> Change 111230 by piso@piso_newluxor on 2006/12/06 23:19:06
P> 
P> 	To workaround a problem when an mbuf is bigger than MCLBYTES
P> 	(and thus not handled by m_megapullup()), introduce & use
P> 	m_jumbo16pullup() that uses 16k jumbo size cluster.
P> 	
P> 	This problem only showed up on traffic generated on a box with 
P> 	a nic tso enabled.

Paolo,

this isn't a fix. Another application will do write(,, 16k + 1) and
m_jumbo16pullup() will fail again. Please backout it, it is a hack.

We need to fix TSO in such way that real packets, that will be
transmitted to wire, will be passed to pfil handlers.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE