From owner-svn-src-all@freebsd.org Wed Mar 23 17:45:47 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8804DADBA68; Wed, 23 Mar 2016 17:45:47 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0BF251C60; Wed, 23 Mar 2016 17:45:47 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x229.google.com with SMTP id l68so206295314wml.0; Wed, 23 Mar 2016 10:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=6uFOavILUJvxuEPFn4X46tbhd7gONc5qEsRuBNHLAPI=; b=CfXauBmub/Ooz+GOQlrcmqnZRCGgenFliw5s3F7qwyJA/kYG6BmwGaUvgBfXcdTRq8 ZT0DiavT7Go/H2xo0aGwXZSWxf+MbDcOvpl53BVraDcz6SSU3oPE3kMmV7sxxG/RCSfN lxXXx7XAcEjTIYztjmgSAmlshS3jOLU2+izaS2uisp9LYQp/IuiYrGqdnm7oMcs4fjfB Jzt2ozO7qJ9i1MLMmn4ckMbh4Y6INrHiLlPblcIVfBB3meDkL0UxEIWQLr0e5WkWTHlK cqw+3JgOVuePlx49ZC8a+pFdtFHwpRvb2Xzvl5N3a4pN93pKPaQs0rWjxIQ0QuWzqiHg l2/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=6uFOavILUJvxuEPFn4X46tbhd7gONc5qEsRuBNHLAPI=; b=g4jkShcZO0z6ueZaKqQKqMdP47HT9WwzNbCHQe+QSddEbWFztLw8JmYu6W2I9//3aP gcZnocAyFw9YwJ+NIxM4+xLiPH/TTDgiwqMkc5+ci6lCgQ/1b2hrN2uEx4PD7zeF5lSe HE9HV0k1FhqiRWrPlM741UzoTaiTAQ3UYfeCDwff93rZQ7r4s+BNyPrCmTTg47Ida+E6 aOaYYC7CbPEj85LJ2QeWNcOKcwgA6rb97rIH1DjuG5A3TcKjY8+u+2EGMBxdsavB9hQK uswDjQgdzOXLlH5GIQ83Vma1BxgcTP3ScY2D+A56kCAH4CIRwGpvhsQOz5sNosXNw8M/ nviQ== X-Gm-Message-State: AD7BkJLS10NkrIuvTFITZkz32w597dbFoFGA0Qyh0GviDE3a+OWXZPLEiTv4+9fGoJClgA== X-Received: by 10.194.5.36 with SMTP id p4mr4777770wjp.167.1458755145550; Wed, 23 Mar 2016 10:45:45 -0700 (PDT) Received: from brick.home (esq247.neoplus.adsl.tpnet.pl. [83.20.136.247]) by smtp.gmail.com with ESMTPSA id y72sm4003173wmh.21.2016.03.23.10.45.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Mar 2016 10:45:44 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Wed, 23 Mar 2016 18:45:37 +0100 From: Edward Tomasz Napierala To: =?iso-8859-1?Q?Jean-S=E9bastien_P=E9dron?= Cc: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297190 - head/sys/kern Message-ID: <20160323174537.GA1826@brick.home> Mail-Followup-To: =?iso-8859-1?Q?Jean-S=E9bastien_P=E9dron?= , Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201603221346.u2MDk1XH029623@repo.freebsd.org> <1458662141.1091.16.camel@freebsd.org> <56F29654.8030806@dumbbell.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56F29654.8030806@dumbbell.fr> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 17:45:47 -0000 On 0323T1412, Jean-Sébastien Pédron wrote: > On 22/03/2016 16:55, Ian Lepore wrote: > > On Tue, 2016-03-22 at 13:46 +0000, Edward Tomasz Napierala wrote: > >> Author: trasz > >> Date: Tue Mar 22 13:46:01 2016 > >> New Revision: 297190 > >> URL: https://svnweb.freebsd.org/changeset/base/297190 > >> > >> Log: > >> Wait for root mount tokens before showing the root mount prompt. > >> This restores the pre-r290196 behaviour, eliminating the need to manually > >> press '.' a couple of times to get USB to finish probing. > >> > >> Note that there's still something wrong with the console (character > >> echoing doesn't quite work), and there's also a reported problem with > >> BHyVe, but those two don't seem related to the problem above. > > > > Just a datapoint on the echoing... it works fine on a serial console, > > it's been years since I've seen glitches at the mountroot prompt. So > > the problem may be in vt or kbdmux. > > I confirm this is a known issue with vt(4): it uses a callout to refresh > the screen, but for reasons unknown to me, the callout is not called > anymore on mountroot prompt. I tried to debug this but failed. Since > then, I didn't have time to work on this again. > > So maybe callouts are disabled in this situation. If there is a way to > detect that, then vt(4) can go back to a "synchronous mode" where it > refreshes the screen after each typed character, like it does when ddb > is active. Looks like that's the case: for some reason the callouts don't work. This trivial hack is a (mostly) working workaround: Index: svn/head/sys/kern/kern_cons.c =================================================================== --- svn/head/sys/kern/kern_cons.c (revision 297210) +++ svn/head/sys/kern/kern_cons.c (working copy) @@ -430,6 +430,7 @@ cngets(char *cp, size_t size, int visible) lp = cp; end = cp + size - 1; for (;;) { + pause("meh", 1); c = cngetc() & 0177; switch (c) { case '\n':