From owner-cvs-all  Tue Sep  3 19:41: 9 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1429D37B401; Tue,  3 Sep 2002 19:41:01 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4465843E3B; Tue,  3 Sep 2002 19:40:59 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.3/8.12.3) with ESMTP id g842erHu018528;
	Tue, 3 Sep 2002 20:40:53 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Tue, 03 Sep 2002 20:40:42 -0600 (MDT)
Message-Id: <20020903.204042.23985384.imp@bsdimp.com>
To: phk@critter.freebsd.dk
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/pccard pccard.c 
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <68113.1031052593@critter.freebsd.dk>
References: <200209031124.g83BOPAh090297@freefall.freebsd.org>
	<68113.1031052593@critter.freebsd.dk>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message: <68113.1031052593@critter.freebsd.dk>
            Poul-Henning Kamp <phk@critter.freebsd.dk> writes:
: In message <200209031124.g83BOPAh090297@freefall.freebsd.org>, Poul-Henning Kam
: p writes:
: >phk         2002/09/03 04:24:25 PDT
: >
: >  Modified files:
: >    sys/dev/pccard       pccard.c 
: >  Log:
: >  Drop another cookie to wet Warners appetite:
: >  
: >  We need to call the drivers interrupt function even though the card is not
: >  multifunction.
: 
: This should make interrupt handling work on non-multifunction cards.

They already work on non mfc cards.  The changes will make it work on
more MFC cards.  most mfc cards don't implement the registers, so they
read as 0xff and a write is a noop.  The non-mfc cards that implement
these registers are the only ones that this fixes :-)

Otherwise, how would most cards work, which aren't mfc?

However, I have an improved set of patches that should do the right
thing...

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message