Date: Sat, 20 Mar 2004 16:05:48 -0500 (EST) From: "Matthew N. Dodd" <mdodd@FreeBSD.ORG> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/net if_ethersubr.c if_fddisubr.c if_iso88025subr.c Message-ID: <20040320160450.T32310@sasami.jurai.net> In-Reply-To: <20040314083743.GC62719@ip.net.ua> References: <200403140524.i2E5OsgV073250@repoman.freebsd.org> <20040314083743.GC62719@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 14 Mar 2004, Ruslan Ermilov wrote:
> : + case AF_ARP:
> : + {
> : + struct arphdr *ah;
> : + ah = mtod(m, struct arphdr *);
> : + ah->ar_hrd = htons(ARPHRD_ETHER);
>
> Is it safe to not do m_pullup() here and there?
Yes. The only codepath that results in the AF_ARP case performs the mbuf
alloction with sufficient size.
I'll be committing this later today.
--
10 40 80 C0 00 FF FF FF FF C0 00 00 00 00 10 AA AA 03 00 00 00 08 00
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040320160450.T32310>