Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 May 2021 09:31:40 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 42881526d401 - main - nullfs: dirty v_object must imply the need for inactivation
Message-ID:  <202105220931.14M9VewJ095537@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=42881526d401e7a9c09241e392b7ffa18cfe11d6

commit 42881526d401e7a9c09241e392b7ffa18cfe11d6
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-05-21 07:30:19 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-05-22 09:30:17 +0000

    nullfs: dirty v_object must imply the need for inactivation
    
    Otherwise pages are cleaned some time later when the lower fs decides
    that it is time to do it.  This mostly manifests itself as delayed
    mtime update, e.g. breaking make-like programs.
    
    Reported by:    mav
    Tested by:      mav, pho
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week
---
 sys/fs/nullfs/null_vnops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/fs/nullfs/null_vnops.c b/sys/fs/nullfs/null_vnops.c
index 5bf470897c08..aeebce4ed086 100644
--- a/sys/fs/nullfs/null_vnops.c
+++ b/sys/fs/nullfs/null_vnops.c
@@ -818,7 +818,7 @@ static int
 null_need_inactive(struct vop_need_inactive_args *ap)
 {
 
-	return (null_want_recycle(ap->a_vp));
+	return (null_want_recycle(ap->a_vp) || vn_need_pageq_flush(ap->a_vp));
 }
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105220931.14M9VewJ095537>