From owner-svn-src-head@freebsd.org Fri Oct 14 17:26:43 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEB7CC123DF; Fri, 14 Oct 2016 17:26:43 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A43C3952; Fri, 14 Oct 2016 17:26:43 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from [76.102.118.237] (helo=[10.0.1.5]) by id.bluezbox.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2 (FreeBSD)) (envelope-from ) id 1bv6Fk-0005Vp-PK; Fri, 14 Oct 2016 10:26:41 -0700 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\)) Subject: Re: svn commit: r307252 - head/sys/arm/broadcom/bcm2835 From: Oleksandr Tymoshenko In-Reply-To: <20161014093726.197f8e05@zapp> Date: Fri, 14 Oct 2016 10:26:41 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201610140300.u9E30r1O061196@repo.freebsd.org> <20161014093726.197f8e05@zapp> To: Andrew Turner X-Mailer: Apple Mail (2.3226) Sender: gonzo@id.bluezbox.com X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: > On Oct 14, 2016, at 1:37 AM, Andrew Turner wrote: > > On Fri, 14 Oct 2016 03:00:53 +0000 (UTC) > Oleksandr Tymoshenko wrote: > >> Author: gonzo >> Date: Fri Oct 14 03:00:53 2016 >> New Revision: 307252 >> URL: https://svnweb.freebsd.org/changeset/base/307252 >> >> Log: >> Make bcm2835_machdep.c optional >> >> bcm2835_machdep.c contains only bits enabled by "options PLATFORM", >> this option available only on ARM, not ARM64 >> >> Modified: >> head/sys/arm/broadcom/bcm2835/files.bcm283x >> >> Modified: head/sys/arm/broadcom/bcm2835/files.bcm283x >> ============================================================================== >> --- head/sys/arm/broadcom/bcm2835/files.bcm283x Fri Oct 14 02:58:31 2016 (r307251) >> +++ head/sys/arm/broadcom/bcm2835/files.bcm283x Fri Oct 14 03:00:53 2016 (r307252) >> @@ -9,7 +9,7 @@ arm/broadcom/bcm2835/bcm2835_fbd.c opti >> arm/broadcom/bcm2835/bcm2835_ft5406.c optional evdev bcm2835_ft5406 >> arm/broadcom/bcm2835/bcm2835_gpio.c optional gpio >> arm/broadcom/bcm2835/bcm2835_intr.c standard >> -arm/broadcom/bcm2835/bcm2835_machdep.c standard >> +arm/broadcom/bcm2835/bcm2835_machdep.c optional platform >> arm/broadcom/bcm2835/bcm2835_mbox.c standard >> arm/broadcom/bcm2835/bcm2835_rng.c optional random >> arm/broadcom/bcm2835/bcm2835_sdhci.c optional sdhci >> > > Any of these files you need should be added to files.arm64 being > optional on the appropriate soc_ value. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 17:26:43 -0000 > On Oct 14, 2016, at 1:37 AM, Andrew Turner = wrote: >=20 > On Fri, 14 Oct 2016 03:00:53 +0000 (UTC) > Oleksandr Tymoshenko wrote: >=20 >> Author: gonzo >> Date: Fri Oct 14 03:00:53 2016 >> New Revision: 307252 >> URL: https://svnweb.freebsd.org/changeset/base/307252 >>=20 >> Log: >> Make bcm2835_machdep.c optional >>=20 >> bcm2835_machdep.c contains only bits enabled by "options PLATFORM", >> this option available only on ARM, not ARM64 >>=20 >> Modified: >> head/sys/arm/broadcom/bcm2835/files.bcm283x >>=20 >> Modified: head/sys/arm/broadcom/bcm2835/files.bcm283x >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/arm/broadcom/bcm2835/files.bcm283x Fri Oct 14 = 02:58:31 2016 (r307251) >> +++ head/sys/arm/broadcom/bcm2835/files.bcm283x Fri Oct 14 = 03:00:53 2016 (r307252) >> @@ -9,7 +9,7 @@ arm/broadcom/bcm2835/bcm2835_fbd.c opti >> arm/broadcom/bcm2835/bcm2835_ft5406.c optional evdev = bcm2835_ft5406 >> arm/broadcom/bcm2835/bcm2835_gpio.c optional gpio >> arm/broadcom/bcm2835/bcm2835_intr.c standard >> -arm/broadcom/bcm2835/bcm2835_machdep.c standard >> +arm/broadcom/bcm2835/bcm2835_machdep.c optional = platform >> arm/broadcom/bcm2835/bcm2835_mbox.c standard >> arm/broadcom/bcm2835/bcm2835_rng.c optional random >> arm/broadcom/bcm2835/bcm2835_sdhci.c optional sdhci >>=20 >=20 > Any of these files you need should be added to files.arm64 being > optional on the appropriate soc_ value. I don=E2=80=99t quite follow. These files are shared between ARM and = ARM64 port, does that mean they should be in both files.arm64 and files.arm? Or in files.arm64 and files.bcm283x?