Date: Wed, 21 Jan 2004 02:20:02 -0800 (PST) From: Volker Stolz <stolz@i2.informatik.rwth-aachen.de> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/61670: [update] comm/garmin-utils 2.0 Message-ID: <200401211020.i0LAK2fG068877@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/61670; it has been noted by GNATS.
From: Volker Stolz <stolz@i2.informatik.rwth-aachen.de>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc: mab@red-bean.com
Subject: Re: ports/61670: [update] comm/garmin-utils 2.0
Date: Wed, 21 Jan 2004 11:17:08 +0100
> >Synopsis: [update] comm/garmin-utils 2.0
For completeness: The comment for the Makefile.inc-patch should read
"...appropriate for all CFLAGS",
because if you have -W in make.conf, the -Werror will be triggered.
The committer might want to consider not adding the Makefile-patch
if it's just necessary for 'obscure' CFLAGS. OTOH, I think the patch
should go in because it took me quite some time to find out why it
wouldn't build -- including a stint into the C99-standard w.r.t.
struct-initialization. Interesting to note that you only have such
insights *after* pressing 's' to submit the PR...
Volker
--
http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
rage against the finite state machine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401211020.i0LAK2fG068877>