From nobody Thu Jul 10 14:09:10 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bdGtZ6cZVz6162y; Thu, 10 Jul 2025 14:09:26 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bdGtZ4NgFz4593; Thu, 10 Jul 2025 14:09:26 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-607434e1821so1376982a12.0; Thu, 10 Jul 2025 07:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752156564; x=1752761364; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=njZ8ywaZvpoFK3DmoCYhgoTbMlPMXSU4CbxiX+7ipLw=; b=gEwPh127FAyR5DZO64yHWw6RNYE0gFeznhAneGFhLBm3ih3ojfqgS2H18GKpfLYWuT +HKNpJDhh9eoSFxxZvZUDg6cm7eSZiXRpzdx2ENrsfU1GrVvhKhrNfp815v0uqF0FWAu YiLLsQT281uKTP32lTSp+sh6avEff4BdhxB7TPVcayPz1ms3eNiijKze8qWLJbhM/HBU kxyqxVDUpKay9k9zwdsVTiNRj8evkSTrzwETLgkaacUdGtK5T38GqMzRrh4nxbAoKJB5 BYvct8ri7lkvZQN3u7x+nEijmNWcVjkZS75GLB95DO00vea912vrChFAr3ZftG+Ade1o c/0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752156564; x=1752761364; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=njZ8ywaZvpoFK3DmoCYhgoTbMlPMXSU4CbxiX+7ipLw=; b=E/3TycZjO/qWLTLcO+c0EbHVitJQ0Y40R/B2He6RNK4J9V4aizSkdAAAuF6sy2e0k6 QTnn1WwD8P/3YssDRLU2PTEM6Z9NWm/op499R7cTfEojmtF70YhizmwFLRyYUbD+tfuZ ajp3mA5HZB32++EylQ+MMnvpnvGCEBcX8JTg/R17ICxSP8geezjfzmgx3uoT9jCgnaQZ U0t+bOB66o03Q7TiEOUvm2MKswSz8ko3saaxIhMzgracZSLJG0VvAIoXXIxyp7QVcWA8 ETBDy5xriISv6WbDfQ+jbSH+Pz4WjNwSkT924aIHc49ijZzno7VT/4k38Dzva8wbxIMS OLZg== X-Forwarded-Encrypted: i=1; AJvYcCUU4BJfCKudH1SzwgQ0wn/NmTPML2HxUIkSTM+unF5kn2uEuYtSAr54KKYCTAqJ3WTGveck7y0EZXSJNm+WGd3niM0o@freebsd.org, AJvYcCW+sKx8BgClqXZCxOFYR9F/6EbY7/+vVW0dJOmXneIP8Kkf7wSHvukT96kxWpMsQfX/cSbNEEM0EHn5VGsBFCI=@freebsd.org, AJvYcCX/87WE0PpeuDxdP1872p+hH2d3+b0K/snVNsK3D3ldHFmECphoWHM2gntIBDMZhCNXcvwvcOEXPuNdDToIaphWMPcrTjo=@freebsd.org X-Gm-Message-State: AOJu0YzopyPkTMwSSJEfUITmbN75wE5FyW/zswwvlHSsBWUwURpbUrjo PCIbn/xaJyNu3oTrJpENH30oKH6AxSqLdS+qN88RJnK3vq9xl/W8JD/5V4kWkiMUvlO5PoDl+17 BZEnirw2I72yR6KvYP5CnphQLRUfDAIDy X-Gm-Gg: ASbGncsP0PJ/Lzs92IWwv/GZFyk067ugwta+pLuVUvZeD/rN38vgP5V1cZIBqxIsXbR Dw/zfsrph2JJUaF1qc5qKxMyLKQ59x8ukK3oOQcjBgQ6KgF67kd8jurgJNlpsD0GX92JN9gUfYO rtgwi/IrG55Yr7bg2wJbvKVEmcnvhY+U71FAHue54xAA0nPITfmhmuXpSjNry4yBePQps+NZErO 4E= X-Google-Smtp-Source: AGHT+IGdZn0ZuRY7dS7GP5hR4wNEVrz8YnnXvQIWrjHjeoTHsJtsNuronceoBU3sD464cfwh6en/N54EdIWwpg4wlBs= X-Received: by 2002:a05:6402:31e7:b0:607:f61f:cc1d with SMTP id 4fb4d7f45d1cf-611c0d4baafmr3038759a12.11.1752156563589; Thu, 10 Jul 2025 07:09:23 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202507062254.566MsbnL090918@gitrepo.freebsd.org> <867c0gcjt3.fsf@ltc.des.dev> In-Reply-To: <867c0gcjt3.fsf@ltc.des.dev> From: Rick Macklem Date: Thu, 10 Jul 2025 07:09:10 -0700 X-Gm-Features: Ac12FXw7QodpahZPufg93CnJj7ZMn_g-uroSK2cf7NAl7BP_rJPVFGrN6sQZRGQ Message-ID: Subject: Re: git: c5d72d29fe0e - main - nfsv4: Add support for the NFSv4 hidden and system attributes To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: Rick Macklem , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bdGtZ4NgFz4593 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] Yep. You can commit it or I can? (You can put reviewed by me if you choose to commit it.) Thanks, rick On Thu, Jul 10, 2025 at 5:27=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > Rick Macklem writes: > > diff --git a/sys/fs/nfsclient/nfs_clvnops.c b/sys/fs/nfsclient/nfs_clvn= ops.c > > index 0049d7edca33..fbfcdafaa06b 100644 > > --- a/sys/fs/nfsclient/nfs_clvnops.c > > +++ b/sys/fs/nfsclient/nfs_clvnops.c > > [...] > > @@ -1092,7 +1100,8 @@ nfs_setattr(struct vop_setattr_args *ap) > > vap->va_gid !=3D (gid_t)VNOVAL || vap->va_atime.tv_sec !=3D V= NOVAL || > > vap->va_mtime.tv_sec !=3D VNOVAL || > > vap->va_birthtime.tv_sec !=3D VNOVAL || > > - vap->va_mode !=3D (mode_t)VNOVAL) && > > + vap->va_mode !=3D (mode_t)VNOVAL || > > + vap->va_flags !=3D (u_long)VNOVAL) && > > (vp->v_mount->mnt_flag & MNT_RDONLY)) > > return (EROFS); > > if (vap->va_size !=3D VNOVAL) { > > vap->va_flags was already checked (in the line just before the first > line of context), albeit without a cast. Coverity erroneously claims > that this causes the entire expression to always be true, because it > thinks VNOVAL and (u_long)VNOVAL are two different values. That's not > the case, but you probably still want this: > > diff --git a/sys/fs/nfsclient/nfs_clvnops.c b/sys/fs/nfsclient/nfs_clvnop= s.c > index fbfcdafaa06b..fa451887e73e 100644 > --- a/sys/fs/nfsclient/nfs_clvnops.c > +++ b/sys/fs/nfsclient/nfs_clvnops.c > @@ -1096,12 +1096,11 @@ nfs_setattr(struct vop_setattr_args *ap) > /* > * Disallow write attempts if the filesystem is mounted read-only= . > */ > - if ((vap->va_flags !=3D VNOVAL || vap->va_uid !=3D (uid_t)VNOVAL = || > + if ((vap->va_flags !=3D (u_long)VNOVAL || vap->va_uid !=3D (uid_t= )VNOVAL || > vap->va_gid !=3D (gid_t)VNOVAL || vap->va_atime.tv_sec !=3D V= NOVAL || > vap->va_mtime.tv_sec !=3D VNOVAL || > vap->va_birthtime.tv_sec !=3D VNOVAL || > - vap->va_mode !=3D (mode_t)VNOVAL || > - vap->va_flags !=3D (u_long)VNOVAL) && > + vap->va_mode !=3D (mode_t)VNOVAL) && > (vp->v_mount->mnt_flag & MNT_RDONLY)) > return (EROFS); > if (vap->va_size !=3D VNOVAL) { > > DES > -- > Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org