From owner-freebsd-bugs  Sun Jul 14 14:50: 9 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9F3B237B405
	for <freebsd-bugs@hub.freebsd.org>; Sun, 14 Jul 2002 14:50:02 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 00F9B43E65
	for <freebsd-bugs@hub.freebsd.org>; Sun, 14 Jul 2002 14:50:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6ELo1JU016835
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 14 Jul 2002 14:50:01 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6ELo1lF016834;
	Sun, 14 Jul 2002 14:50:01 -0700 (PDT)
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7D27E37B400
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 14 Jul 2002 14:41:57 -0700 (PDT)
Received: from www.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3FB2943E4A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 14 Jul 2002 14:41:57 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.4/8.12.4) with ESMTP id g6ELfuOT023382
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 14 Jul 2002 14:41:56 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.4/8.12.4/Submit) id g6ELfuHg023381;
	Sun, 14 Jul 2002 14:41:56 -0700 (PDT)
Message-Id: <200207142141.g6ELfuHg023381@www.freebsd.org>
Date: Sun, 14 Jul 2002 14:41:56 -0700 (PDT)
From: Ian Jackson <ian@davenant.greenend.org.uk>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: bin/40572: vipw prints silly message if $EDITOR fails
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         40572
>Category:       bin
>Synopsis:       vipw prints silly message if $EDITOR fails
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 14 14:50:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Ian Jackson
>Release:        4.4
>Organization:
SGO
>Environment:
FreeBSD lsd.relativity.greenend.org.uk 4.4-RELEASE FreeBSD 4.4-RELEASE #49: Sun Jul 14 02:08:15 BST 2002     kaet@lsd.relativity.greenend.org.uk:/usr/obj/usr/src/sys/000004lsd  i386

>Description:
when the external EDITOR invoked by vipw fails (exits nonzero),
vipw prints a message involving strerror(errno), instead of the
exit status of the failed program.
>How-To-Repeat:
bash-2.05# EDITOR=false vipw
vipw: false: Operation not permitted
vipw: /etc/master.passwd: unchanged
bash-2.05# 

>Fix:
src/lib/libutil/pw_util.c:pw_edit and all its callers would have to
be changed to allow it other error returns besides -1 setting errno.
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message