From owner-freebsd-ports@FreeBSD.ORG Sat Mar 27 17:15:03 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C435616A4CE; Sat, 27 Mar 2004 17:15:03 -0800 (PST) Received: from hood.oook.cz (hood.oook.cz [212.27.205.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 037B043D39; Sat, 27 Mar 2004 17:15:03 -0800 (PST) (envelope-from pav@FreeBSD.org) Received: from hood.oook.cz (localhost.oook.cz [127.0.0.1]) by hood.oook.cz (8.12.11/8.12.11) with ESMTP id i2S1F1Fu075362; Sun, 28 Mar 2004 03:15:01 +0200 (CEST) (envelope-from pav@FreeBSD.org) Received: (from pav@localhost) by hood.oook.cz (8.12.11/8.12.11/Submit) id i2S1F11p075361; Sun, 28 Mar 2004 03:15:01 +0200 (CEST) (envelope-from pav@FreeBSD.org) X-Authentication-Warning: hood.oook.cz: pav set sender to pav@FreeBSD.org using -f From: Pav Lucistnik To: Thomas-Martin Seck In-Reply-To: <20040327200136.31711.qmail@laurel.tmseck.homedns.org> References: <20040327200136.31711.qmail@laurel.tmseck.homedns.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-d27M173kRp5PaCFBBCCM" Message-Id: <1080436501.75008.5.camel@hood.oook.cz> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sun, 28 Mar 2004 03:15:01 +0200 cc: SADA Kenji cc: freebsd-ports@FreeBSD.org Subject: Re: treating OPTIONS X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: pav@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2004 01:15:03 -0000 --=-d27M173kRp5PaCFBBCCM Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable V so, 27. 03. 2004 v 21:01, Thomas-Martin Seck p=ED=B9e: > * SADA Kenji [gmane.os.freebsd.devel.ports]: >=20 > > .if exists(${LOCALBASE}/lib/libldap.so) > > WITH_LDAP=3D yes > > OPTIONS+=3D LDAP "Support for LDAP queries" on > > .else > > OPTIONS+=3D LDAP "Support for LDAP queries" off > > .endif >=20 > Please do not do this. IMHO, ports that autotune themselves are a bad > idea and abusing OPTIONS for this is even worse. If you - as the > maintainer - decide that LDAP support is optional, default the port to > not include it. Period. If the user wants LDAP she can always say so > herself, either via the commandline or via 'make config'. Why not? This is a common practice that port autodetects optional dependencies and automatically enable/disable them. --=20 Pav Lucistnik Quantum physics was developed in the 1930's, as a result of a bet between Albert Einstein and Niels Bohr, to see who could come up with the most ridiculous theory and still have it published. --=-d27M173kRp5PaCFBBCCM Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?= =?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAZicVntdYP8FOsoIRAtLkAJ9H2IvrpG0hjwVMxf1pr03VwV5BJgCgsGjt lj0g0txNwXwSQg4n+GXEWk4= =KQwS -----END PGP SIGNATURE----- --=-d27M173kRp5PaCFBBCCM--