From owner-svn-ports-all@freebsd.org Tue Dec 8 11:45:18 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 166D59D4095; Tue, 8 Dec 2015 11:45:18 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D2C0C1396; Tue, 8 Dec 2015 11:45:16 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 258C4BDC8B; Tue, 8 Dec 2015 12:45:15 +0100 (CET) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 05E00BDC66; Tue, 8 Dec 2015 12:45:15 +0100 (CET) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id 0D9736142; Tue, 8 Dec 2015 12:45:13 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id 2AE621664AE4; Tue, 8 Dec 2015 12:45:13 +0100 (CET) Date: Tue, 08 Dec 2015 12:45:12 +0100 From: Mathieu Arnold To: =?UTF-8?Q?Ren=C3=A9_Ladan?= cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r403235 - head/emulators/fuse-roms Message-ID: <290DB4608132EE92B98C7908@ogg.in.absolight.net> In-Reply-To: References: <201512072100.tB7L0Gnj081781@repo.freebsd.org> <0644124C99ECCEA1DF8E9EC0@atuin.in.mat.cc> <98D8063B4D072B57DAA53BE8@ogg.in.absolight.net> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 11:45:18 -0000 +--On 8 d=C3=A9cembre 2015 11:46:01 +0100 Ren=C3=A9 Ladan = wrote: | 2015-12-08 11:29 GMT+01:00 Mathieu Arnold : |> +--On 8 d=C3=A9cembre 2015 10:08:19 +0100 Ren=C3=A9 Ladan = |> wrote: |> | 2015-12-08 10:04 GMT+01:00 Mathieu Arnold : |> |> +--On 7 d=C3=A9cembre 2015 21:00:16 +0000 Rene Ladan = |> |> wrote: |> |> | +DOCS_PLIST_FILES=3D%%DOCSDIR%%/rom-distribution.txt |> |>=20 |> |> When possible, don't use %%FOO%% thingies in PLIST_FILES, you can use |> |> ${DOCSDIR} directly. |> |>=20 |> | I think I tried that before. It would almost work but "poudriere |> | testport" would fail. |>=20 |> Then there was a bug in poudriere testport at that time. It now works. |>=20 | That was in the previous version (3.10.9 ?). 'make check-plist' worked | fine. I'll change the line next time (but why is it bad?) The only reason there are %%foo%% thingies is because pkg-plist is a static file, and we need some way to do the variable expansion in them. The PLIST_FILES is in the Makefile, you can put the correct variables directly. --=20 Mathieu Arnold