From owner-cvs-all Thu Jul 19 15:50:10 2001 Delivered-To: cvs-all@freebsd.org Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19]) by hub.freebsd.org (Postfix) with ESMTP id 90D0737B401; Thu, 19 Jul 2001 15:50:01 -0700 (PDT) (envelope-from mike@coffee.q9media.com) Received: (from mike@localhost) by coffee.q9media.com (8.11.2/8.11.2) id f6JN6wl56621; Thu, 19 Jul 2001 19:06:58 -0400 (EDT) (envelope-from mike) Date: Thu, 19 Jul 2001 19:06:58 -0400 From: Mike Barcroft To: Dag-Erling Smorgrav Cc: obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/nohup nohup.c nohup.1 Message-ID: <20010719190658.B56479@coffee.q9media.com> References: <200107192125.f6JLPAE95986@freefall.freebsd.org> <20010719153226.B84709@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from des@ofug.org on Fri, Jul 20, 2001 at 12:37:17AM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Jul 20, 2001 at 12:37:17AM +0200, Dag-Erling Smorgrav wrote: > "David O'Brien" writes: > > On Fri, Jul 20, 2001 at 12:05:55AM +0200, Dag-Erling Smorgrav wrote: > > > Mike Barcroft writes: > > > > Approved by: des > > > also reviewed by same. > > The assumption is if you approved something, you reviewed it. > > Not necessarily - I sometimes approve commits to code I maintain on > the basis of trust in the requesting committer's abilities. In this > particular case, however, Mike is my mentee, so I review every patch > he commits to pieces before I approve it. I made that assumption too, but I can see why you would also like to be listed on the 'Reviewed by' line. So in future I'll keep you on the 'Reviewed by' line. Problem solved. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message