Date: Fri, 28 Aug 2015 12:00:26 -0400 From: Allan Jude <allanjude@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com>, "O'Connor, Daniel" <darius@dons.net.au> Cc: Alexey Dokuchaev <danfe@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Xin LI <delphij@freebsd.org> Subject: Re: svn commit: r287236 - head/bin/df Message-ID: <55E0859A.50504@freebsd.org> In-Reply-To: <CD4128C8-BC71-4FC6-B4FD-9EFBA835AB39@gmail.com> References: <201508280044.t7S0ixfW038766@repo.freebsd.org> <20150828044312.GA88538@FreeBSD.org> <CAGHfRMDw0=-ze4cd7mAoHO_n%2Bt8NdYsR0On2YE5=s_gQ4=xveg@mail.gmail.com> <20150828060458.GA20642@FreeBSD.org> <E8E510CD-EF49-489D-8DD2-1EFEBE0E470A@dons.net.au> <CD4128C8-BC71-4FC6-B4FD-9EFBA835AB39@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dJ82jxcGNPMGiLpMjFWL5NFTbJKSOcqre Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2015-08-28 03:48, Garrett Cooper wrote: >=20 >> On Aug 28, 2015, at 00:24, O'Connor, Daniel <darius@dons.net.au> wrote= : >> >>> On 28 Aug 2015, at 15:34, Alexey Dokuchaev <danfe@freebsd.org> wrote:= >>>> On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: >>>>> On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev <danfe@freebsd.or= g> wrote: >>>>>> On Fri, Aug 28, 2015 at 12:44:59AM +0000, Xin LI wrote: >>>>>> New Revision: 287236 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/287236 >>>>>> >>>>>> Log: >>>>>> Use exit() instead of return in main(). >>>>> >>>>> Because?.. >>>> >>>> Probably because of libxo... >>> >>> I'm just wondering how hard is it to write sensible commit logs. :( >> >> To put it in a hopefully more helpful way.. >> Please write why your change is doing something, not what it is doing.= >> >> Saying what it is doing is OK if it's really hairy, but 99% of the tim= e that isn't the case. >> >> Assuming this is a libxo thing the commit log should have been somethi= ng like.. >> "Use exit out of main otherwise libxo will not flush properly" >> (or something similar) >> >> Although it would be surprising if libxo required you to use exit().. >=20 > Libxo (iirc) doesn't install atexit handlers, which means that you need= to use exit (or a reason facsimile) in order for it to flush its file st= reams. >=20 > This is unintuitive though. I wish it did the right thing as part of in= itializing the streams.. >=20 This has nothing to do with libxo. libxo has an optional atexit handler, but as long as you call xo_finish(), then everything is flushed and the xo handle is closed. xo_finish() is indeed called the line before this change. --=20 Allan Jude --dJ82jxcGNPMGiLpMjFWL5NFTbJKSOcqre Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJV4IWaAAoJEBmVNT4SmAt+NyMQAJkp9LUGi8AHAaWrN3jQnWvC CxWHAMLKYd8OsVQgY7Cz+HBuVHFC2xOzsZuPj549/4rqRlQEC5fy6K22zxcZNHbT Fqe1P6E0E0nxXXjWtURxZigPQTctwgDb0ndBat7xcdtvqDf/Wojpn0mxvylGyOkP l4M60MIm2vMiE9kQkl4zYqce090ch3pTLjovRyBUA8G5+DbZk08XHH8jVoB/98Hx V3k3ds1gdqaYMhugBWBPDExZTkvvs045nOSkYqxuBBPbY8MGV4ht07xKGwIFldBK uqT1pS4GgTzPni2Zvr8jWVDTVuzC9ad8WLqAWq7jrGpGPwZQ5mqEUW8ZTQRqrelo kQI66OXySO4Dtv6h8Xhs3WnkgD2GeJ4W1UI1VQK7jA71nr2/ji/RIJCYyi1Ho/Tq eN079pPXBfVALN2KG0jJgUUBMAzfO6AxZo9ywmNyHoGfuEa+iG0wW6xq+IsEE+yK Ep5hRRMESU3TM44Ie91GwXnp5QgFzOU7/LGDR6OK1nNGf0QpZVrp8cO8ZafXBfyw jqyXNdYnkzXSbN0uieJKKmPoY/WUqBRyRIkOGHnYqFjHp5+NioZPe8bq2nXHP+Bg VKhzhuRG2lHfEGHdUe3wHzlrJgNacHU8BZ0aQRJsJYaNWQef4rjZQTIXrSATLExx IqDo+Yu1QCpYuu4JqNb0 =2D6K -----END PGP SIGNATURE----- --dJ82jxcGNPMGiLpMjFWL5NFTbJKSOcqre--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55E0859A.50504>