Date: Mon, 16 Apr 2018 15:43:47 +0300 From: Lev Serebryakov <lev@FreeBSD.org> To: Adriaan de Groot <adridg@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467478 - in head: devel/p5-subversion devel/py-subversion devel/ruby-subversion devel/subversion devel/subversion/files java/java-subversion www/mod_dav_svn Message-ID: <9c06c3d3-25d7-97d9-8510-92a59e66a43b@FreeBSD.org> In-Reply-To: <22429616.yAmutGOGha@a-pc> References: <201804161153.w3GBr3HW062183@repo.freebsd.org> <22429616.yAmutGOGha@a-pc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16.04.2018 15:31, Adriaan de Groot wrote:
> It's a bit unusual to leave PORTREVISION in the Makefile when it's 0, isn't
> it? It doesn't really reduce churn, either, in the line-based diffs subversion
> supports.
It is protection to avoid problems if PORTREVISION will be set in
Makefile.common.
>> MAINTAINER= lev@FreeBSD.org
>> COMMENT= Perl bindings for Version control system
>> @@ -32,6 +32,9 @@ CONFIGURE_ARGS+= --without-gnome-keyring \
>>
>> ALL_TARGET= swig-pl-lib swig-pl
>> INSTALL_TARGET= install-swig-pl
>> +
>> +#CPPFLAGS+= -I${LOCALBASE}/lib/perl5/${PERL_VER}/${PERL_ARCH}/CORE \
>> +# -Isubversion/bindings/swig/proxy
>
> It's also unusual to leave commented out bits-n-bobs from previous versions
> around; that's what subversion is for :)
And it is my fault, really, it is even not from previous versions, but
from experiments in progress of porting new version.
--
// Lev Serebryakov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9c06c3d3-25d7-97d9-8510-92a59e66a43b>