Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Dec 2011 17:00:42 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric <dim@freebsd.org>
Subject:   Re: svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211
Message-ID:  <201112211700.42772.jhb@freebsd.org>
In-Reply-To: <CAJ-Vmont2wOF=TkT1CmZt4Gp0iOc7ZYmfQpjW=8j1=F5DQGNwQ@mail.gmail.com>
References:  <201112211716.pBLHGhDH078507@svn.freebsd.org> <CAJ-Vmont2wOF=TkT1CmZt4Gp0iOc7ZYmfQpjW=8j1=F5DQGNwQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, December 21, 2011 4:52:04 pm Adrian Chadd wrote:
> Erm, why did you do this without first getting clearance from someone
> who has the hardware to test it?
> 
> Just because it looks obviously wrong to you, doesn't at all mean that
> it's "wrong". It's quite possible that the driver _requires_ those
> bits to be written to the hardware as 0.
> 
> 
> I'd appreciate it if would please revert this and other ath/hal
> changes until I've had time to research them and test them out.

I agree it should be reviewed, but if you are seriously depending on
the fact that the shifted values are beyond the edge of the word boundary
and so the result "wraps" to zero, then I'd question the sanity of your code.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112211700.42772.jhb>