From owner-freebsd-fs@FreeBSD.ORG  Tue Jun  2 15:17:23 2015
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1DB5BA61
 for <freebsd-fs@FreeBSD.org>; Tue,  2 Jun 2015 15:17:23 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0769612E2
 for <freebsd-fs@FreeBSD.org>; Tue,  2 Jun 2015 15:17:23 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t52FHMj1061925
 for <freebsd-fs@FreeBSD.org>; Tue, 2 Jun 2015 15:17:22 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-fs@FreeBSD.org
Subject: [Bug 199804] ZFS: i/o error - all block copies unavailable
Date: Tue, 02 Jun 2015 15:17:23 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 10.1-RELEASE
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: tsoome@me.com
X-Bugzilla-Status: Open
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-fs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-199804-3630-xfAHg4jRlB@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-199804-3630@https.bugs.freebsd.org/bugzilla/>
References: <bug-199804-3630@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jun 2015 15:17:23 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199804

--- Comment #2 from Toomas Soome <tsoome@me.com> ---
actually the fix itself is buggy:) the basic idea is correct, but the size of
the zero filled buffer is wrong, the correct code is:

                        if (BP_IS_HOLE(&bp)) {
                                memset(dnode_cache_buf, 0, 
                                    dnode->dn_datablkszsec << 
                                    SPA_MINBLOCKSHIFT);
                                rc = 0;
                        } else
                                rc = zio_read(spa, &bp, dnode_cache_buf);

as the BP_PSIZE() or BP_LSIZE() is 512B at that point (for 512B sector size at
least), and indicates the size of BP itself, not the size of the hole - so the
original (bad) fix did zero out only first 512B and rest of the buffer did
return garbage.

This fix is verified by hashing the whole file and checking against file on
disk and file read to memory by this reader code.

-- 
You are receiving this mail because:
You are the assignee for the bug.