From owner-svn-src-all@freebsd.org Fri Oct 23 11:47:02 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DED024441B4; Fri, 23 Oct 2020 11:47:02 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CHjBY6WKtz42RP; Fri, 23 Oct 2020 11:47:01 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 09NBktWn018798 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 23 Oct 2020 14:46:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 09NBktWn018798 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 09NBkt7P018797; Fri, 23 Oct 2020 14:46:55 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 23 Oct 2020 14:46:54 +0300 From: Konstantin Belousov To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r366936 - head/sys/net Message-ID: <20201023114654.GY2643@kib.kiev.ua> References: <202010221222.09MCM8qo048407@repo.freebsd.org> <20201022164804.GQ2643@kib.kiev.ua> <69bfca24-40a9-552a-62b3-8ab7b46ff3c7@selasky.org> <20201023094621.GW2643@kib.kiev.ua> <966178e3-078f-66d3-8baa-6672b998422e@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <966178e3-078f-66d3-8baa-6672b998422e@selasky.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4CHjBY6WKtz42RP X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [0.18 / 15.00]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; NEURAL_SPAM_SHORT(0.05)[0.046]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; NEURAL_SPAM_MEDIUM(0.08)[0.077]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.05)[0.053]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2020 11:47:02 -0000 On Fri, Oct 23, 2020 at 01:26:04PM +0200, Hans Petter Selasky wrote: > On 2020-10-23 11:46, Konstantin Belousov wrote: > > On Fri, Oct 23, 2020 at 10:04:12AM +0200, Hans Petter Selasky wrote: > > > On 2020-10-22 19:54, Hans Petter Selasky wrote: > > > > On 2020-10-22 18:48, Konstantin Belousov wrote: > > > > > sys/systm.h already includes sys/param.h.  Also, sys/param.h already > > > > > includes > > > > > sys/types.h. > > > > > > > > I'll have a look tomorrow at this. Thanks for pointing out. > > > > > > It appears sys/systm.h needs sys/types.h included first: > > Normally you do > > #include > > #include > > and I do not see why it would not work in this case. > > > > > > > > > In file included from /usr/img/freebsd.svn/src/sys/sys/systm.h:44: > > > > ./machine/atomic.h:230:1: error: unknown type name 'u_char'; did you mean 'char'? > > > > ATOMIC_CMPSET(char); > > > > > > --HPS > > Hi, > > The following works, but it doesn't make much difference. It makes a difference because this is an idiomatic an intended use of the headers. > > Do we have a script or tool, which can do this? I am not aware of. > > --HPS > > > Index: sys/net/if_infiniband.c > > =================================================================== > > --- sys/net/if_infiniband.c (revision 366936) > > +++ sys/net/if_infiniband.c (working copy) > > @@ -30,9 +30,8 @@ > > __FBSDID("$FreeBSD$"); > > #include > > +#include > > #include > > -#include > > -#include > > #include > > #include > > #include