From owner-svn-ports-all@freebsd.org  Tue May 24 12:50:51 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58126B47C48;
 Tue, 24 May 2016 12:50:51 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 323C61983;
 Tue, 24 May 2016 12:50:50 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from [192.168.1.21] (176.red-83-34-249.dynamicip.rima-tde.net
 [83.34.249.176])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 3BF2943C31;
 Tue, 24 May 2016 07:50:48 -0500 (CDT)
Subject: Re: svn commit: r415493 - in head/games/libretro-cores: . files
To: Mathieu Arnold <mat@FreeBSD.org>, marino@freebsd.org,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
References: <201605190700.u4J70sfs011294@repo.freebsd.org>
 <307385ca-1cd1-83ae-1a66-b2a7210b5054@marino.st>
 <2A9F124F55BB011FD665C0A4@ogg.in.absolight.net>
Reply-To: marino@freebsd.org
From: John Marino <freebsd.contact@marino.st>
Message-ID: <17614e8e-01c9-eeeb-4752-758e5d7112fc@marino.st>
Date: Tue, 24 May 2016 14:50:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <2A9F124F55BB011FD665C0A4@ogg.in.absolight.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 May 2016 12:50:51 -0000

On 5/24/2016 2:31 PM, Mathieu Arnold wrote:
> +--On 24 mai 2016 12:05:25 +0200 John Marino <freebsd.contact@marino.st>
> wrote:
> |>  do-build:
> |>  	@for dir in ${CORE_DIRS}; do \
> |> -	  ${ECHO_MSG} "===>  Building for ${PKGNAME}: core $${dir} (`date`)"; \
> |> -	  if [ -f ${WRKSRC}/$${dir}/Makefile.freebsd ]; then \
> |> -	    (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD}
> |> ${MAKE_FLAGS} Makefile.freebsd ${_MAKE_JOBS} ${MAKE_ARGS}); \ -	  elif [
> |> -f ${WRKSRC}/$${dir}/Makefile.libretro ]; then \
> |> -	    (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD}
> |> ${MAKE_FLAGS} Makefile.libretro ${_MAKE_JOBS} ${MAKE_ARGS}); \ +
> |> ${ECHO_MSG} "===>  Building for ${PKGNAME}: core ${dir} ($$(date))"; \ +
> |> 	  cd ${WRKSRC}/${dir}; \
> |
> | We think this is a mistake:
> | changing "cd ${WRKSRC}/$${dir};" to "cd ${WRKSRC}/${dir};"
> | ("core $${dir}" => "core ${dir}" is wrong too but that's only an echo
> | issue)
> |
> | I'm wondering how this is working on FreeBSD actually ...
>
> Mmmm, good catch, I changed it back from a make .for to a shell one at the
> last minute and messed it up.

There's a second problem too.
You have to revert this one:

-	  ${CP} $$(find ${WRKSRC}/$${dir} -name "*.so") 
${STAGEDIR}/${PREFIX}/libexec/libretro/; \
+	  ${INSTALL_LIB} $$(find ${WRKSRC}/${dir}/ -name "*.so") 
${STAGEDIR}/${PREFIX}/libexec/libretro); \

The last ")" prevents installation from installating.  It fails for us 
outright on the during staging.

Thanks,
John