From owner-svn-src-all@freebsd.org Tue Jun 16 17:08:52 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1CC9E34486F; Tue, 16 Jun 2020 17:08:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 49mZRR2zG3z4PH8; Tue, 16 Jun 2020 17:08:51 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id lF4ojFvs5ng7KlF4pjQ80V; Tue, 16 Jun 2020 11:08:48 -0600 X-Authority-Analysis: v=2.3 cv=ecemg4MH c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=nTHF0DUjJn0A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=7HFaC1jlLhaPMhqbVQkA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id 3C83E40B; Tue, 16 Jun 2020 10:08:45 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id 05GH8i6n019564; Tue, 16 Jun 2020 10:08:44 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id 05GH8ibS019561; Tue, 16 Jun 2020 10:08:44 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202006161708.05GH8ibS019561@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Ian Lepore cc: Toomas Soome , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r362217 - head/stand/common In-reply-to: <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org> References: <202006160705.05G753T4057972@repo.freebsd.org> <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org> Comments: In-reply-to Ian Lepore message dated "Tue, 16 Jun 2020 11:01:02 -0600." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 16 Jun 2020 10:08:44 -0700 X-CMAE-Envelope: MS4wfDqB0mL8zaufKyc1+W26v6YKj82HnwVMsq9baS4aS6TCdXib7Z06j2ioj23A9y++uZqYnMer9utfmmpsRSBMSAgjYDitI/vPNGwCQHvmXUmgTiIoCD6D RVw+4vfChuPIWanxQy4iri5YtAXOaQZvBIGi3nLxwg66aBx5+p4AFyXJzsCp3MYqyaqXOwFb35/uYunLdzIUs6cG6bx9CZcIzXEhVibhrwuGYFErJQZ3cVzk lDQO9kGMQqg9HZzBdOZV/VzP+nLGP4IQYv7UrIxtKxLRGT7n97UfG57NtIbUzdL2w1LH5wByK4jGbgBlJHP+Qg== X-Rspamd-Queue-Id: 49mZRR2zG3z4PH8 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2020 17:08:52 -0000 In message <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org>, Ian Le pore writes: > On Tue, 2020-06-16 at 07:05 +0000, Toomas Soome wrote: > > Author: tsoome > > Date: Tue Jun 16 07:05:03 2020 > > New Revision: 362217 > > URL: https://svnweb.freebsd.org/changeset/base/362217 > > > > Log: > > loader: variable i is unused without MBR/GPT support built in > > > > Because i is only used as index in for loop, declare it in for > > statement. > > > > As much as I prefer doing it this way, style(9) doesn't allow for > variable declarations inside a for() statement (or even inside a local > block, which is just too 1980s for me, but it is still our standard). Doesn't this use stack for a shorter period of time or does the compiler optimize this, making this change moot? The tradeoff is a few extra bytes of stack for a longer period of time vs a few extra instructions incrementing and decrementing the stack pointer. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.