From owner-freebsd-hackers  Fri Mar  8 20:49:25 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from bazooka.trit.org (bazooka.trit.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP id 1B6C637B404
	for <hackers@freebsd.org>; Fri,  8 Mar 2002 20:49:19 -0800 (PST)
Received: by bazooka.trit.org (Postfix, from userid 1000)
	id A6C6E3E2F; Sat,  9 Mar 2002 04:49:14 +0000 (UTC)
Received: from bazooka (localhost [127.0.0.1])
	by bazooka.trit.org (Postfix) with ESMTP
	id A577F3C12E; Sat,  9 Mar 2002 04:49:14 +0000 (UTC)
To: hackers@freebsd.org
Cc: Jordan DeLong <fracture@allusion.net>
Subject: Re: bin/34744: Add -a (same as -PpR) flag to cp(1) 
In-Reply-To: <200202090347.g193lXd55117@cs6668125-184.austin.rr.com>; from fracture@allusion.net on "Fri, 8 Feb 2002 21:47:33 -0600 (CST)"
Date: Sat, 09 Mar 2002 04:49:09 +0000
From: Dima Dorfman <dima@trit.org>
Message-Id: <20020309044914.A6C6E3E2F@bazooka.trit.org>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

Jordan DeLong <fracture@allusion.net> wrote:
> 
> >Number:         34744
> >Category:       bin
> >Synopsis:       Add -a (same as -PpR) flag to cp(1)
> >Description:
> 	some other cp(1) implementations (such as GNU cp) provide a -a
> 	flag, which just means -PpR.  somewhat useful.

Does anybody on -hackers object to this change?  I find myself using
`cp -RPp` frequently and would welcome this shortcut.  If nobody
objects, I'll clean up the patch (minor style and mdoc nits) before
committing.

Thanks.

> >Fix:
> 
> diff -ruN cp.dist/cp.1 cp/cp.1
> --- cp.dist/cp.1	Thu Aug 16 05:01:03 2001
> +++ cp/cp.1	Fri Feb  8 21:44:40 2002
> @@ -77,6 +77,13 @@
>  .Pp
>  The following options are available:
>  .Bl -tag -width flag
> +.It Fl a
> +Same as specifying the
> +.Fl R
> +.Fl P
> +and
> +.Fl p
> +flags.
>  .It Fl H
>  If the
>  .Fl R
> @@ -226,7 +233,9 @@
>  .Pp
>  The
>  .Fl v
> -option is non-standard and its use in scripts is not recommended.
> +and
> +.Fl a
> +options are non-standard and use in scripts is not recommended.
>  .Sh SEE ALSO
>  .Xr mv 1 ,
>  .Xr rcp 1 ,
> diff -ruN cp.dist/cp.c cp/cp.c
> --- cp.dist/cp.c	Wed Jan 30 09:15:46 2002
> +++ cp/cp.c	Fri Feb  8 21:43:28 2002
> @@ -102,7 +102,7 @@
>  	char *target;
>  
>  	Hflag = Lflag = Pflag = 0;
> -	while ((ch = getopt(argc, argv, "HLPRfiprv")) != -1)
> +	while ((ch = getopt(argc, argv, "aHLPRfiprv")) != -1)
>  		switch (ch) {
>  		case 'H':
>  			Hflag = 1;
> @@ -112,6 +112,10 @@
>  			Lflag = 1;
>  			Hflag = Pflag = 0;
>  			break;
> +		case 'a':
> +			Rflag = 1;
> +			pflag = 1;
> +			/* FALLTHROUGH */
>  		case 'P':
>  			Pflag = 1;
>  			Hflag = Lflag = 0;
> diff -ruN cp.dist/utils.c cp/utils.c
> --- cp.dist/utils.c	Wed Jan 30 09:15:46 2002
> +++ cp/utils.c	Fri Feb  8 21:39:05 2002
> @@ -312,7 +312,7 @@
>  {
>  
>  	(void)fprintf(stderr, "%s\n%s\n",
> -"usage: cp [-R [-H | -L | -P]] [-f | -i] [-pv] src target",
> -"       cp [-R [-H | -L | -P]] [-f | -i] [-pv] src1 ... srcN directory");
> +"usage: cp [-R [-H | -L | -P]] [-f | -i] [-apv] src target",
> +"       cp [-R [-H | -L | -P]] [-f | -i] [-apv] src1 ... srcN directory");
>  	exit(EX_USAGE);
>  }
> 
> 
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-bugs" in the body of the message
> 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message